Free resources after aborting a swap

[h4sh3d]

When a swap is aborted in the first seconds/minutes (before funding) some resources are not fully free.

As pointed out by @TheCharlatan there is no way we can avoid the issue between peerd and swapd, as peerd as no notion of swaps (but we could add a 'black list' in peerd so when we send a message we filter by swap id and try to send only if not in the list, but that's a bit ugly IMO). The bug reside in syncers, where the free is not always done properly.

[2022-12-27T11:10:47Z INFO  farcaster_node::swapd::runtime] Starting swap: c00a25f5-9f76-4995-bc3d-a2cc4ed1369c
[2022-12-27T11:10:48Z INFO  farcaster_node::farcasterd::runtime] Service swap<c00a25f5-9f76-4995-bc3d-a2cc4ed1369c> is now connected
[2022-12-27T11:10:48Z INFO  farcaster_node::event] c00a25f5-9f76-4995-bc3d-a2cc4ed1369c | Trade state transition Swapd Launched -> Swapd Running
[2022-12-27T11:10:48Z INFO  farcaster_node::swapd::runtime] c00a25f5-9f76-4995-bc3d-a2cc4ed1369c as Alice Taker | Proposing to take swap to Maker remote peer
[2022-12-27T11:10:48Z INFO  farcaster_node::swapd::runtime] c00a25f5-9f76-4995-bc3d-a2cc4ed1369c as Alice Taker | Swap State Machine state transition Start Alice Taker -> Alice Init Taker
[2022-12-27T11:10:48Z INFO  farcaster_node::peerd::runtime] c00a25f5-9f76-4995-bc3d-a2cc4ed1369c | Sent the Alice taker commit protocol message
[2022-12-27T11:10:51Z INFO  farcaster_node::swapd::runtime] c00a25f5-9f76-4995-bc3d-a2cc4ed1369c as Alice Taker | Sent reveal peer message to peerd
[2022-12-27T11:10:51Z INFO  farcaster_node::swapd::runtime] c00a25f5-9f76-4995-bc3d-a2cc4ed1369c as Alice Taker | Swap State Machine state transition Alice Init Taker -> Alice Taker Maker Commit
[2022-12-27T11:10:51Z INFO  farcaster_node::peerd::runtime] c00a25f5-9f76-4995-bc3d-a2cc4ed1369c | Sent the reveal Alice protocol message
[2022-12-27T11:10:53Z INFO  farcaster_node::swapd::runtime] c00a25f5-9f76-4995-bc3d-a2cc4ed1369c as Alice Taker | Handling reveal with wallet
[2022-12-27T11:10:53Z INFO  farcaster_node::swapd::wallet] c00a25f5-9f76-4995-bc3d-a2cc4ed1369c | Proof successfully verified
[2022-12-27T11:10:53Z INFO  farcaster_node::swapd::runtime] c00a25f5-9f76-4995-bc3d-a2cc4ed1369c as Alice Taker | Swap State Machine state transition Alice Taker Maker Commit -> Alice Reveal
[2022-12-27T11:10:57Z INFO  farcaster_node::swapd::runtime] c00a25f5-9f76-4995-bc3d-a2cc4ed1369c as Alice Taker | Aborted swap.
[2022-12-27T11:10:57Z INFO  farcaster_node::swapd::runtime] c00a25f5-9f76-4995-bc3d-a2cc4ed1369c as Alice Taker | Swap State Machine state transition Alice Reveal -> Swap End: Failure Abort
[2022-12-27T11:10:57Z WARN  farcaster_node::farcasterd::trade_state_machine] Aborted swap c00a25f5-9f76-4995-bc3d-a2cc4ed1369c
[2022-12-27T11:10:57Z INFO  farcaster_node::farcasterd::stats] Swapped(0) | Refunded(0) / Punished(0) | Aborted(1) | Initialized(2) / AwaitingFundingXMR(0) / AwaitingFundingBTC(0) / FundedXMR(1) / FundedBTC(0) / FundingCanceledXMR(0) / FundingCanceledBTC(0)
[2022-12-27T11:10:57Z INFO  farcaster_node::farcasterd::stats] Swap success =    0%
[2022-12-27T11:10:57Z INFO  farcaster_node::event] c00a25f5-9f76-4995-bc3d-a2cc4ed1369c | Trade state machine ended Swapd Running -> End
[2022-12-27T11:10:57Z INFO  farcaster_node::swapd::runtime] c00a25f5-9f76-4995-bc3d-a2cc4ed1369c as Alice Taker | Terminating swap<c00a25f5-9f76-4995-bc3d-a2cc4ed1369c>
[2022-12-27T11:11:04Z ERROR microservices::esb::controller] ESB request processing error: error sending message from peerd<152210119665618866786428799779337603919 035a4a57ba986b22518e13f27d241cc19bcd7b3b52a9babd5ee09d196d7895b958@65.108.96.98:7067> to swap<c00a25f5-9f76-4995-bc3d-a2cc4ed1369c>. Details: service is offline or not responding
[2022-12-27T11:12:38Z INFO  farcaster_node::event] Syncer state transition Start -> Awaiting Syncer Request
[2022-12-27T11:12:38Z INFO  farcaster_node::event] Syncer state machine ended Awaiting Syncer Request -> End
[2022-12-27T11:12:38Z INFO  farcaster_node::event] Syncer state transition Start -> Awaiting Syncer Request
[2022-12-27T11:12:39Z INFO  farcaster_node::event] Syncer state machine ended Awaiting Syncer Request -> End
[2022-12-27T11:13:44Z INFO  farcaster_node::syncerd::syncer_state] Monero | Incremented height 1254098
[2022-12-27T11:13:44Z ERROR microservices::esb::controller] ESB request processing error: error sending message from Monero (Testnet) syncer to swap<c00a25f5-9f76-4995-bc3d-a2cc4ed1369c>. Details: service is offline or not responding
[2022-12-27T11:13:45Z INFO  farcaster_node::swapd::syncer_client] 57655650-29a9-4bb8-b90a-d086a34511fd | Tx Accordant Lock final with 1 confirmations
[2022-12-27T11:13:46Z INFO  farcaster_node::swapd::syncer_client] 57655650-29a9-4bb8-b90a-d086a34511fd | Watching Buy transaction (b89120845065ee9e3ad9129754f36613296f4abcdae7c74992e56e62a6c089a5)
[2022-12-27T11:13:46Z INFO  farcaster_node::swapd::syncer_client] 57655650-29a9-4bb8-b90a-d086a34511fd | Cancel transaction created
[2022-12-27T11:13:46Z INFO  farcaster_node::swapd::syncer_client] 57655650-29a9-4bb8-b90a-d086a34511fd | Buy transaction created
[2022-12-27T11:13:46Z INFO  farcaster_node::swapd::runtime] 57655650-29a9-4bb8-b90a-d086a34511fd as Alice Taker | Broadcasting Buy tx(b89120845065ee9e3ad9129754f36613296f4abcdae7c74992e56e62a6c089a5)
[2022-12-27T11:13:46Z INFO  farcaster_node::swapd::runtime] 57655650-29a9-4bb8-b90a-d086a34511fd as Alice Taker | Swap State Machine state transition Alice Accordant Lock -> Alice Buy Procedure Signature
[2022-12-27T11:13:56Z WARN  farcaster_node::swapd::syncer_client] 57655650-29a9-4bb8-b90a-d086a34511fd | Tx Buy was re-orged or dropped from the mempool. Re-broadcasting tx
[2022-12-27T11:13:56Z INFO  farcaster_node::swapd::syncer_client] 57655650-29a9-4bb8-b90a-d086a34511fd | Tx Buy not on the mempool
[2022-12-27T11:14:13Z INFO  farcaster_node::swapd::syncer_client] 57655650-29a9-4bb8-b90a-d086a34511fd | Tx Buy on mempool but hasn't been mined
[2022-12-27T11:14:38Z INFO  farcaster_node::event] Syncer state transition Start -> Awaiting Syncer Request
[2022-12-27T11:14:38Z INFO  farcaster_node::event] Syncer state machine ended Awaiting Syncer Request -> End
[2022-12-27T11:14:38Z INFO  farcaster_node::event] Syncer state transition Start -> Awaiting Syncer Request
[2022-12-27T11:14:39Z INFO  farcaster_node::event] Syncer state machine ended Awaiting Syncer Request -> End
[2022-12-27T11:14:53Z INFO  farcaster_node::syncerd::syncer_state] Monero | Incremented height 1254099
[2022-12-27T11:14:53Z ERROR microservices::esb::controller] ESB request processing error: error sending message from Monero (Testnet) syncer to swap<c00a25f5-9f76-4995-bc3d-a2cc4ed1369c>. Details: service is offline or not responding
[2022-12-27T11:14:54Z INFO  farcaster_node::swapd::syncer_client] 57655650-29a9-4bb8-b90a-d086a34511fd | Tx Accordant Lock final

Important lines are

[2022-12-27T11:11:04Z ERROR microservices::esb::controller] ESB request processing error: error sending message from peerd<152210119665618866786428799779337603919 035a4a57ba986b22518e13f27d241cc19bcd7b3b52a9babd5ee09d196d7895b958@65.108.96.98:7067> to swap<c00a25f5-9f76-4995-bc3d-a2cc4ed1369c>. Details: service is offline or not responding
...
[2022-12-27T11:13:44Z ERROR microservices::esb::controller] ESB request processing error: error sending message from Monero (Testnet) syncer to swap<c00a25f5-9f76-4995-bc3d-a2cc4ed1369c>. Details: service is offline or not responding
...
[2022-12-27T11:14:53Z ERROR microservices::esb::controller] ESB request processing error: error sending message from Monero (Testnet) syncer to swap<c00a25f5-9f76-4995-bc3d-a2cc4ed1369c>. Details: service is offline or not responding