Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better UX when forms fail #567

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Better UX when forms fail #567

wants to merge 1 commit into from

Conversation

wbazant
Copy link
Collaborator

@wbazant wbazant commented Nov 3, 2024 •
edited
Loading

  • show errors
  • set submitting to false but don't lose form state

Closes #562

I chose this verbiage for error messages:

wbazant@wbazant-19-01:~/dev/falling-fruit-web$ ag 'failed: ' | grep toast
src/components/form/ReportModal.js:33:      toast.error(`Report submission failed: ${e.message}`)
src/components/photo/PhotoUploader.js:39:            toast.error(`Photo upload failed: ${error.message}`)
src/redux/typeSlice.js:60:      toast.error(`Adding new type failed: ${action.error.message}`)
src/redux/locationSlice.js:213:      toast.error(`Location submission failed: ${action.error.message}`)
src/redux/locationSlice.js:225:      toast.error(`Location editing failed: ${action.error.message}`)
src/redux/locationSlice.js:232:      toast.error(`Review submission failed: ${action.error.message}`)
src/redux/locationSlice.js:244:      toast.error(`Review editing failed: ${action.error.message}`)
src/redux/locationSlice.js:253:      toast.error(`Review deletion failed: ${action.error.message}`)

@wbazant
Better UX when forms fail
dbad0b6 
- show errors
- set submitting to false but don't lose form state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let the user know when submission fails due to bad connection
1 participant
@wbazant