Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After adding a photo, the submit button slides down #556

Open
wbazant opened this issue Nov 1, 2024 · 3 comments
Open

After adding a photo, the submit button slides down #556

wbazant opened this issue Nov 1, 2024 · 3 comments
Assignees
Labels
bug Unexpected problems or unintended behavior design desktop Specific to desktop layout

Comments

@wbazant
Copy link
Collaborator

wbazant commented Nov 1, 2024

The review form on desktop is under the location page, so it usually needs to be scrolled down to. The photo upload and submit button are at the bottom, and reachable after the user has scrolled to them. Then uploading the photo grows the element, resulting in this:
Screenshot from 2024-11-01 10-35-48

The submit button is temporarily lost, producing confusion and a small amount of annoyance.

@wbazant wbazant added bug Unexpected problems or unintended behavior desktop Specific to desktop layout design labels Nov 1, 2024
@ahmedhalac
Copy link
Contributor

Hi @wbazant. Can I try to fix this?

@wbazant
Copy link
Collaborator Author

wbazant commented Nov 7, 2024

Please do, thanks! Could I also recruit you as a reviewer for #555? If you check out that branch, see if my fix does what it says and if you can spot any related problems, and if you say it's all good I'll merge it in - and then you can base your solution on top of the updated main branch.

@ahmedhalac
Copy link
Contributor

Hi @wbazant. Just a quick question. What is the best approach here? To set submit button fixed position or? Can you help me with the best solution? As I see it will be always pushed down by uploaded photo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problems or unintended behavior design desktop Specific to desktop layout
Projects
None yet
Development

No branches or pull requests

2 participants