Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the workaround for list without previously wanted map #552

Open
wbazant opened this issue Oct 31, 2024 · 0 comments
Open

Remove the workaround for list without previously wanted map #552

wbazant opened this issue Oct 31, 2024 · 0 comments
Labels
mobile Specific to mobile layout

Comments

@wbazant
Copy link
Collaborator

wbazant commented Oct 31, 2024

Follow-up from #543 (comment).

The list relies on the map being loaded in a few ways now:

  • bounds of a last map view needed to fetch list location
  • width and height for calculating new bounds in place search
  • after searching, we move the map, which changes the lastMapView, and changes the URL

There is a workaround in place - if there's no map loaded but we're opening a list, e.g. after a refresh, load it it come back. It's not easy to remove it, but we can get the width and height the map would have, and repair a bunch of places. It could however move us to a better design, so worth keeping track of the idea!

@wbazant wbazant added the mobile Specific to mobile layout label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Specific to mobile layout
Projects
None yet
Development

No branches or pull requests

1 participant