fix(auth): validation of ipv6/ipv4 #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validation for ipv6 was sort of broken where for example `::1` was being sent as `1`, therefore, logins were broken. This PR fixes it by using nodejs `net.isIPv4()` & `net.isIPv6` for ipv4 and ipv6 validation. possibly related to and fixes #795
gauthier-th
approved these changes
Jun 12, 2024
|
🎉 This PR is included in version 1.9.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
bonswouar
pushed a commit
to bonswouar/jellyseerr
that referenced
this pull request
Jun 14, 2024
validation for ipv6 was sort of broken where for example `::1` was being sent as `1`, therefore, logins were broken. This PR fixes it by using nodejs `net.isIPv4()` & `net.isIPv6` for ipv4 and ipv6 validation. possibly related to and fixes fallenbagel#795
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From #470, validation for ipv6 was sort of broken where for example
::1was being sent as1, therefore, logins were broken. This PR fixes it by using nodejsnet.isIPv4()&net.isIPv6for ipv4 and ipv6 validation.Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed