Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(overriderules): apply override rules during request only for non-admin/non-auto-approve users #1197

Merged
merged 1 commit into from
Dec 30, 2024
Merged

fix(overriderules): apply override rules during request only for non-admin/non-auto-approve users #1197

merged 1 commit into from
Dec 30, 2024

Conversation

fallenbagel
Copy link
Owner

@fallenbagel fallenbagel commented Dec 30, 2024 •
edited
Loading

Description

Updated the logic of override rules to be applied during the request phase and not during send-to-arr phase. In addition, override rules will only apply for non-admin/non-advanced-request users.

Override rule logic has been changed to the following:

  • Admins and users with auto-approve permissions bypass override rules, retaining their flexibility to choose their options.
  • Other users have their requests automatically adjusted based on applicable override rules prior to approval.

Screenshot (if UI-related)

To-Dos

  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

@fallenbagel
fix(overriderules): apply override rules during request only for non-…
49c7dd9 
…admin/non-auto-approve users

Updated the logic of override rules to be applied during the request phase and not during
send-to-arr phase. In addition, override rules will only apply for non-admin/non-auto-approve users.

fix #1195
@fallenbagel fallenbagel merged commit 8da4870 into develop Dec 30, 2024
7 checks passed
@fallenbagel fallenbagel deleted the fix-override-rules branch December 30, 2024 02:25
@fallenbagel
Copy link
Owner Author

🎉 This PR is included in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

fallenbagel added a commit that referenced this pull request Dec 30, 2024
@fallenbagel
fix(overriderules): apply override rules to tv shows during request
da2bd72 
Forgot to apply override rules to tv shows on #1197

fix #1195
@fallenbagel fallenbagel mentioned this pull request Dec 30, 2024
Merged
3 tasks
fallenbagel added a commit that referenced this pull request Dec 30, 2024
@fallenbagel
fix(overriderules): apply override rules to tv shows during request (#…
f8a8ebd 
…1198)

Forgot to apply override rules to tv shows on #1197

fix #1195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauthier-th gauthier-th Awaiting requested review from gauthier-th gauthier-th is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug with override rules
1 participant
@fallenbagel