Cannot pass BasicAuth in URLs #1027
Comments
danwilldev
added
awaiting triage
fallenbagel
added
confirmed
1 task
fallenbagel
added a commit
that referenced
this issue
Oct 31, 2024
This PR adds extraction of basic authentication credentials from the URL and then pass the credentials as the `Authorization` header. And then credentials are removed from the URL before being passed to fetch. This is done because fetch request cannot be constructed using a URL with credentials fix #1027
fallenbagel
added a commit
that referenced
this issue
Oct 31, 2024
This commit adds extraction of basic authentication credentials from the URL and then pass the credentials as the `Authorization` header. And then credentials are removed from the URL before being passed to fetch. This is done because fetch request cannot be constructed using a URL with credentials fix #1027
2 tasks
|
@danwilldev could you test |
|
@fallenbagel I have tested on my machine and can now connect services with basic auth. Thanks for the fix guys :D |
bonswouar
pushed a commit
to bonswouar/jellyseerr
that referenced
this issue
Nov 10, 2024
…enbagel#1062) This commit adds extraction of basic authentication credentials from the URL and then pass the credentials as the `Authorization` header. And then credentials are removed from the URL before being passed to fetch. This is done because fetch request cannot be constructed using a URL with credentials fix fallenbagel#1027
|
🎉 This issue has been resolved in version 2.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
thibodelanghe
pushed a commit
to thibodelanghe/jellyseerr
that referenced
this issue
Dec 18, 2024
…enbagel#1062) This commit adds extraction of basic authentication credentials from the URL and then pass the credentials as the `Authorization` header. And then credentials are removed from the URL before being passed to fetch. This is done because fetch request cannot be constructed using a URL with credentials fix fallenbagel#1027
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When trying to connect a service, jellyseerr no longer accepts basic auth credentials as part of the URL string.
Version
2.0.1
Steps to Reproduce
Try to connect any service eg Sonarr to Jellyseerr. Pass basic auth as part of the string and observe the below log-line after failing to connect.
Screenshots
No response
Logs
[error][Radarr]: [Radarr] Failed to retrieve profiles: Request cannot be constructed from a URL that includes credentials: https://username:Password@urlhere/radarr/api/v3/qualityProfile?apikey=apiKeyHerePlatform
desktop
Device
Server
Operating System
Ubuntu
Browser
Firefox
Additional Context
As per @fallenbagel on discord. "2.0.0 introduced fetch and url constructor doesn't like basic auth in url."
Code of Conduct
The text was updated successfully, but these errors were encountered: