Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libscap): add defines in userspace_flags_helpers.h for alpine-musl/centos7 builds that don't have them #331

Merged
merged 1 commit into from
May 13, 2022

Conversation

LucaGuerra
Copy link
Contributor

Signed-off-by: Luca Guerra luca@guerra.sh

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area driver-kmod

/area driver-ebpf

/area libscap

/area libsinsp

/area tests

/area proposals

What this PR does / why we need it:

This PR aims to fix the following build errors, with musl for alpine:

/build-static/release/falcosecurity-libs-repo/falcosecurity-libs-prefix/src/falcosecurity-libs/userspace/libscap/../../driver/ppm_flag_helpers.h:1279:14: error: 'LOCK_EX' was not declared in this scope
 1279 |  if (flags & LOCK_EX)
      |              ^~~~~~~

and similar

and with CentOS 7:

/build/release/falcosecurity-libs-repo/falcosecurity-libs-prefix/src/falcosecurity-libs/userspace/libscap/../../driver/ppm_flag_helpers.h:1369:7: error: 'QFMT_VFS_OLD' was not declared in this scope

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

…ave them

Signed-off-by: Luca Guerra <luca@guerra.sh>
@poiana
Copy link
Contributor

poiana commented May 13, 2022

Hi @LucaGuerra. Thanks for your PR.

I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jasondellaluce
Copy link
Contributor

/ok-to-test

@FedeDP
Copy link
Contributor

FedeDP commented May 13, 2022

🙏

@FedeDP FedeDP mentioned this pull request May 13, 2022
53 tasks
@FedeDP
Copy link
Contributor

FedeDP commented May 13, 2022

/test build-libs-bundled-deps

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented May 13, 2022

LGTM label has been added.

Git tree hash: 37fb6b49b44e3f9e26ab77a968f90b434a15b8e3

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @LucaGuerra!
/approve

@poiana
Copy link
Contributor

poiana commented May 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 8b18444 into falcosecurity:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants