-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(libscap): add defines in userspace_flags_helpers.h for alpine-musl/centos7 builds that don't have them #331
fix(libscap): add defines in userspace_flags_helpers.h for alpine-musl/centos7 builds that don't have them #331
Conversation
…ave them Signed-off-by: Luca Guerra <luca@guerra.sh>
Hi @LucaGuerra. Thanks for your PR. I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
🙏 |
/test build-libs-bundled-deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 37fb6b49b44e3f9e26ab77a968f90b434a15b8e3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @LucaGuerra!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Luca Guerra luca@guerra.sh
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
/area libscap
What this PR does / why we need it:
This PR aims to fix the following build errors, with musl for alpine:
and similar
and with CentOS 7:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: