Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an event for default rule "Set Setuid or Setgid bit" #163

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

GLVSKiriti
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind tests

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area commands

/area pkg

/area events

What this PR does / why we need it:
Added an event for default rule "Set Setuid or Setgid bit" as mentioned here

Which issue(s) this PR fixes:

Fixes #162

Special notes for your reviewer:

Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
@GLVSKiriti
Copy link
Contributor Author

Similarly this also producing Notice log on executing event code as expected

setsetuidorsetgidbit

@GLVSKiriti
Copy link
Contributor Author

GLVSKiriti commented Apr 4, 2024

@FedeDP @leogr Here the rule triggers fine when running the event code! When I use run command its working fine. But when I use test command even the rule triggers and produces log but still why test is showing timeout?

Any Idea why is this happening?

doubt1

…entation

Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
@GLVSKiriti
Copy link
Contributor Author

@FedeDP Now every thing works fine the error is due to name convention in documentation. This is very important before adding a function!!

setuidorsetgiddbit

)

func SetSetuidorSetgidbit(h events.Helper) error {
filename := "created-by-falco-event-generator"
Copy link
Contributor

@FedeDP FedeDP Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as for the folders, can we create a temp file? https://pkg.go.dev/os#CreateTemp

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! just did that

Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/approve

@poiana
Copy link

poiana commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, GLVSKiriti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Apr 5, 2024

LGTM label has been added.

Git tree hash: 3b3f460b08c538cbe59ca0f74bd3bd2c7234bfed

@poiana poiana added the approved label Apr 5, 2024
@poiana poiana merged commit cda10d7 into falcosecurity:main Apr 5, 2024
4 checks passed
@GLVSKiriti GLVSKiriti deleted the SetSetuidOrSetSetgidBit branch April 5, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an event for default rule "Set Setuid or Setgid bit"
3 participants