Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link by replacing it with valid url #126

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

GLVSKiriti
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind tests

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area commands

/area pkg

/area events

What this PR does / why we need it:
Fix broken link by replacing it with valid url

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
@poiana poiana added kind/documentation Improvements or additions to documentation dco-signoff: yes labels Mar 17, 2024
@poiana poiana requested review from FedeDP and leogr March 17, 2024 15:38
@poiana poiana added the size/XS label Mar 17, 2024
Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
@GLVSKiriti
Copy link
Contributor Author

Is this fix fine??

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this fix fine??

Yes! Good catch, thank you 👏

@poiana
Copy link

poiana commented Mar 26, 2024

LGTM label has been added.

Git tree hash: 4cb6da881253721c1961369c42cc53c33c613ab9

@poiana
Copy link

poiana commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GLVSKiriti, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr leogr added this to the v0.12.0 milestone Mar 26, 2024
@poiana poiana merged commit d691c7c into falcosecurity:main Mar 26, 2024
4 checks passed
@GLVSKiriti GLVSKiriti deleted the BrokenLinkFix branch March 26, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants