Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an event for default stable rule "Find AWS Credentials" #124

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

GLVSKiriti
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind tests

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area commands

/area pkg

/area events

What this PR does / why we need it:
Added an event for default stable rule "Find AWS Credentials"

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
@GLVSKiriti
Copy link
Contributor Author

GLVSKiriti commented Mar 22, 2024

Below screenshot where test is successful and on left terminal it produces warning message on running event code as expected

FindAwsCredentials

@GLVSKiriti
Copy link
Contributor Author

@leogr KIndly also review this PR!

Question: Will the rule triggers even if find utility not exists?

Ans: No it wont trigger if find utility not exists so we can skip the action in this case!!

@GLVSKiriti
Copy link
Contributor Author

@FedeDP In this also just executing find command is enough to trigger this stable rule

func FindAwsCredentials(h events.Helper) error {
path, err := exec.LookPath("find")
if err != nil {
// if we don't have a find, just bail
return &events.ErrSkipped{
Reason: "find utility not found in path",
}
}
cmd := exec.Command(path, ".aws/credentials")
err = cmd.Run()

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, GLVSKiriti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Apr 3, 2024

LGTM label has been added.

Git tree hash: 2b0491143bb8f40f69b4cd861bbf6194aed56acf

@poiana poiana added the approved label Apr 3, 2024
@poiana poiana merged commit d5a7eee into falcosecurity:main Apr 3, 2024
4 checks passed
@GLVSKiriti GLVSKiriti deleted the findAwsCredentials branch April 3, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants