Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an event for default rule "Write below monitored dir" #102

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

GLVSKiriti
Copy link
Contributor

@GLVSKiriti GLVSKiriti commented Mar 14, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind tests

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area commands

/area pkg

/area events

What this PR does / why we need it:
Added event for default rule write_below_monitored_dir as mentioned here

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
@GLVSKiriti
Copy link
Contributor Author

I enabled the event and tested it and its working fine i.e, it generates error message in left terminal!

output1

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a minor note. Overall, SGTM. Thank you!

events/syscall/write_below_monitored_dir.go Outdated Show resolved Hide resolved
Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
@GLVSKiriti GLVSKiriti requested a review from leogr March 22, 2024 16:28
@poiana
Copy link

poiana commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GLVSKiriti, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Mar 25, 2024

LGTM label has been added.

Git tree hash: ddbfe14fb5481b11d990d26ababb687d4bf03c02

@poiana poiana merged commit 9abd1ec into falcosecurity:main Mar 25, 2024
4 checks passed
@GLVSKiriti GLVSKiriti deleted the write_below_monitored_dir branch March 25, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants