-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix running of k8saudit actions #725
Conversation
Welcome @cam-at-tactiq! It looks like this is your first PR to falcosecurity/charts 🎉 |
Signed-off-by: Cam Smith <cam@tactiq.io>
Hey @cam-at-tactiq, thanks for the PR. Could you please update the docs as stated here: https://github.com/falcosecurity/charts#contributing? |
Hi @alacuku, what changes would you expect to see in the docs? This PR bumps the chart version and updates the changelog, but doesn't change anything user facing. The examples given in the event-generator docs will work with this change whereas before they don't. See #723 |
It would help if you ran |
Signed-off-by: Cam Smith <cam@tactiq.io>
Done, ty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 538469df33cc3f4ab9fc32f56c153063a18bfc6f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, cam-at-tactiq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind chart-release
/area event-generator-chart
What this PR does / why we need it:
Currently users who follow the example config given here will see event-generator fail to start.
That's because the rules that match that regexp will only run when the
--all
flag is provided because they are marked as disabled.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This is my first contribution in Falcosecurity, please let me know if there is more I can do to make this as smooth as possible for review/acceptance.
Checklist