Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: priority level "info" to "informational" #302

Merged
merged 1 commit into from
Feb 8, 2022
Merged

fix: priority level "info" to "informational" #302

merged 1 commit into from
Feb 8, 2022

Conversation

kirin-13
Copy link
Contributor

@kirin-13 kirin-13 commented Dec 30, 2021

Signed-off-by: kirin-13 kirin_13@163.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@kirin-13
Copy link
Contributor Author

/assign @bencer

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Would you like to fix that also here 👇 ?
https://github.com/falcosecurity/falco/blob/master/falco.yaml#L92-L95

@leogr
Copy link
Member

leogr commented Feb 2, 2022

Closing and reopening to trigger the CI
/close

@poiana poiana closed this Feb 2, 2022
@leogr
Copy link
Member

leogr commented Feb 2, 2022

/reopen

@poiana
Copy link
Contributor

poiana commented Feb 2, 2022

@leogr: Closed this PR.

In response to this:

Closing and reopening to trigger the CI
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana reopened this Feb 2, 2022
@poiana
Copy link
Contributor

poiana commented Feb 2, 2022

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kirin-13

Could you bump the chart version, please? 🙏

Our CI needs that to automatically publish the new chart.

Otherwise, SGTM.

Signed-off-by: kirin <kirin_13@163.com>
@kirin-13
Copy link
Contributor Author

kirin-13 commented Feb 8, 2022

hi @leogr
Updated charts version, please re-review. 🙏

@leogr
Copy link
Member

leogr commented Feb 8, 2022

Closing and reopening to trigger the CI
/close

@poiana poiana closed this Feb 8, 2022
@poiana
Copy link
Contributor

poiana commented Feb 8, 2022

@leogr: Closed this PR.

In response to this:

Closing and reopening to trigger the CI
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr
Copy link
Member

leogr commented Feb 8, 2022

/reopen

@poiana
Copy link
Contributor

poiana commented Feb 8, 2022

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana reopened this Feb 8, 2022
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Feb 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kirin-13, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the lgtm label Feb 8, 2022
@poiana
Copy link
Contributor

poiana commented Feb 8, 2022

LGTM label has been added.

Git tree hash: b1f560429d834e8abd46d38acb99f97ca563bc61

@poiana poiana added the approved label Feb 8, 2022
@poiana poiana merged commit cc07b87 into falcosecurity:master Feb 8, 2022
@kirin-13 kirin-13 deleted the informational branch February 8, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants