Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cythonize generated router code #1664

Open
kgriffs opened this issue Feb 5, 2020 · 1 comment
Open

Cythonize generated router code #1664

kgriffs opened this issue Feb 5, 2020 · 1 comment
Labels
needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks! needs-decision perf proposal
Milestone

Comments

@kgriffs
Copy link
Member

kgriffs commented Feb 5, 2020

Let's consider using cython.inline() to compile the generated router code. If we do this, we will need to be very transparent about what it is doing, and also fall back if the compilation fails due to a missing compiler, etc. Also we would need to solve #1550 first.

By default, cython.inline() behaves as follows (according to @vytas7's testing):

  • Saves the snippet to a temporary file (e.g., ~/.cython/inline/_cython_inline_7723cfda1cea8e31cc3829cad4d730f3.pyx)
  • Cythonizes the temporary *.pyx file
  • Imports and returns the compiled module
@kgriffs
Copy link
Member Author

kgriffs commented Feb 5, 2020

Note that even once #1550 is solved, we will still need to document that compiling it could take a few moments, slowing down the first request (if that is how we implement #1550).

@kgriffs kgriffs mentioned this issue Aug 3, 2021
14 tasks
@vytas7 vytas7 added Hacktoberfest needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks! labels Oct 7, 2021
@vytas7 vytas7 modified the milestones: Version 3.1, Version 3.2 Dec 20, 2021
@vytas7 vytas7 mentioned this issue May 22, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks! needs-decision perf proposal
Projects
None yet
Development

No branches or pull requests

2 participants