From 8daa29a33b0ff0b20ae09e3a16a389ac2a093f54 Mon Sep 17 00:00:00 2001
From: Joe Stein <joe@splitwise.com>
Date: Wed, 25 Dec 2019 14:17:28 -0800
Subject: [PATCH] Extract constants in Faker::Music

---
 lib/faker/music/music.rb | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/lib/faker/music/music.rb b/lib/faker/music/music.rb
index 28d1a665a0..b58a70fd27 100644
--- a/lib/faker/music/music.rb
+++ b/lib/faker/music/music.rb
@@ -3,6 +3,11 @@
 module Faker
   class Music < Base
     class << self
+      NOTE_LETTERS = %w[C D E F G A B].freeze
+      ACCIDENTAL_SIGNS = ['b', '#', ''].freeze
+      KEY_TYPES = ['', 'm'].freeze
+      CHORD_TYPES = ['', 'maj', '6', 'maj7', 'm', 'm7', '-7', '7', 'dom7', 'dim', 'dim7', 'm7b5'].freeze
+
       ##
       # Produces the name of a key/note, using letter notation.
       #
@@ -49,7 +54,7 @@ def instrument
       #
       # @faker.version 1.6.4
       def keys
-        %w[C D E F G A B]
+        NOTE_LETTERS
       end
 
       ##
@@ -59,7 +64,7 @@ def keys
       #
       # @faker.version 1.6.4
       def key_variants
-        ['b', '#', '']
+        ACCIDENTAL_SIGNS
       end
 
       ##
@@ -72,7 +77,7 @@ def key_variants
       #
       # @faker.version 1.6.4
       def key_types
-        ['', 'm']
+        KEY_TYPES
       end
 
       ##
@@ -82,7 +87,7 @@ def key_types
       #
       # @faker.version 1.6.4
       def chord_types
-        ['', 'maj', '6', 'maj7', 'm', 'm7', '-7', '7', 'dom7', 'dim', 'dim7', 'm7b5']
+        CHORD_TYPES
       end
 
       ##