Suggestion: Convert parameters to keyword arguments

[supremebeing7]

I find myself using Faker::Internet.slug pretty regularly, but I almost never need to specify words and almost always specify the glue. So, my tests and factories are littered with Faker::Internet.slug(nil, '-'). It seems to me it would read better as Faker::Internet.slug(glue: '-').

I think this would also provide some clarity on other Faker classes involving multiple arguments. For example, the somewhat ambiguous

Faker::Lorem.sentence(3, false, 4)

would become

Faker::Lorem.sentence(word_count: 3, supplemental: false, random_words_to_add: 4)

It's more verbose, but I'd prefer that than having to consult the faker docs every time.

[stympy]

I like this idea -- I'd love a PR. :)

This is good timing, as I just dropped Ruby 1.9.3 from Travis, so the next gem version can have breaking changes like this.

[supremebeing7]

👍

I can try to whip up one in the coming week.

[bpleslie]

This has been implemented. I think this can be closed now 👍

[vbrazo]

True. Thanks 👍