Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Generators with External Calls #2852

Closed
stefannibrasil opened this issue Nov 13, 2023 · 3 comments
Closed

Deprecate Generators with External Calls #2852

stefannibrasil opened this issue Nov 13, 2023 · 3 comments

Comments

@stefannibrasil
Copy link
Contributor

stefannibrasil commented Nov 13, 2023

[this issue will be assigned to participants of the RubyConf2023 Hack Day]

Some generators pull data from external services. We would like to move away from depending on external services.

As part of this task:

  • list out any generators that make external calls
  • add a deprecation message to these generators

Here's an example of how to deprecate a generator:

@vveleva
Copy link

vveleva commented Nov 13, 2023

Currently working on this one!

@raysapida
Copy link
Contributor

I saw two other generators, Placeholdit and Avatar, that used URLs but it doesn't look like they were calling the service

@stefannibrasil
Copy link
Contributor Author

Thank you @raysapida for working on this! Now we know for sure we are not relying on any external services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants