Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese for Faker::Games::Orverwatch #2275

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

may-solty
Copy link
Contributor

@may-solty may-solty commented Mar 6, 2021

Add Japanese for Faker::Games::Overwatch.hero
Thank you!

irb(main):001:0> Faker::Config.locale = :ja
=> :ja
irb(main):004:0> Faker::Games::Overwatch.hero
=> "トレーサー"

@@ -53,6 +53,9 @@ ja:
sushi: ["アオヤギ", "アカガイ", "アジ", "アナゴ", "アマエビ", "アワビ", "イカ", "イクラ", "ウナギ", "カキ", "カツオ", "カニ", "カンパチ", "キス", "コハダ", "サーモン", "サザエ", "サバ", "サヨリ", "サワラ", "シマアジ", "シラコ", "スズキ", "タイ", "タコ", "タマゴ", "ノドグロ", "ハマグリ", "ハマチ", "ヒラメ", "ブリ", "ホタテ", "ホタルイカ", "ボタンエビ", "マグロ", "マス", "ミルガイ"]

games:
overwatch:
heroes: ["D.Va", "アッシュ", "アナ", "ウィドウメイカー", "ウィンストン", "エコー", "オリーサ", "ゲンジ", "ザリア", "シグマ", "シンメトラ", "ジャンクラット", "ゼニヤッタ", "ソルジャー76", "ソンブラ", "トレーサー", "トールビョーン", "ドゥームフィスト", "ハンゾー", "バスティオン", "バティスト", "ファラ", "ブリギッテ", "マクリー", "マーシー", "メイ", "モイラ", "ラインハルト", "リーパー", "ルシオ", "レッキング・ボール", "ロードホッグ"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea about the locale, but is D.Va intended in the data ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@psibi Yes, it is. The D.Va is intended in the data. The D.Va is also written as D.Va in Japanese.

@psibi psibi merged commit 677ac8f into faker-ruby:master Mar 6, 2021
@psibi
Copy link
Member

psibi commented Mar 6, 2021

Thank you!

This was referenced Mar 12, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants