Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add es-AR locale #2258

Merged
merged 15 commits into from
Feb 11, 2021
Merged

Add es-AR locale #2258

merged 15 commits into from
Feb 11, 2021

Conversation

fcolacilli
Copy link
Contributor

Added translations and tests for Spanish from Argentina.

@fcolacilli
Copy link
Contributor Author

Can I get some help on the "Tests / Ruby head" failing test? What should I do to correct it?

@psibi
Copy link
Member

psibi commented Feb 7, 2021

@fcolacilli Can you disable that test ? I don't think we need to make it pass it on Ruby head. CC: @Zeragamba @vbrazo and others.

@psibi psibi merged commit 95302b6 into faker-ruby:master Feb 11, 2021
@psibi
Copy link
Member

psibi commented Feb 11, 2021

Thank you!

@fcolacilli
Copy link
Contributor Author

Thanks. Sorry for the delay. How could I disable the test if I wanted to make future PRs?

@psibi
Copy link
Member

psibi commented Feb 11, 2021

No worries. It has been already disabled in the master by @koic . :-)

fcolacilli added a commit to fcolacilli/faker that referenced this pull request Feb 11, 2021
* Name locales

* Address locales

* Football locales

* Basketball locales

* Military locales

* Compass locales

* Tests refactoring and data correction

* Phone numbers locales

* Bank name locales

* Color name locales

* Currency name locales

* Team sport locales

* Nation locales

* Company locales

* Rubocop corrections
fcolacilli added a commit to fcolacilli/faker that referenced this pull request Feb 11, 2021
fcolacilli added a commit to fcolacilli/faker that referenced this pull request Feb 11, 2021
@fcolacilli fcolacilli deleted the spanish-argentina branch February 11, 2021 15:49
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants