-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add es-AR locale #2258
Merged
Merged
Add es-AR locale #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can I get some help on the "Tests / Ruby head" failing test? What should I do to correct it? |
@fcolacilli Can you disable that test ? I don't think we need to make it pass it on Ruby head. CC: @Zeragamba @vbrazo and others. |
Thank you! |
Thanks. Sorry for the delay. How could I disable the test if I wanted to make future PRs? |
No worries. It has been already disabled in the master by @koic . :-) |
fcolacilli
added a commit
to fcolacilli/faker
that referenced
this pull request
Feb 11, 2021
* Name locales * Address locales * Football locales * Basketball locales * Military locales * Compass locales * Tests refactoring and data correction * Phone numbers locales * Bank name locales * Color name locales * Currency name locales * Team sport locales * Nation locales * Company locales * Rubocop corrections
fcolacilli
added a commit
to fcolacilli/faker
that referenced
this pull request
Feb 11, 2021
This reverts commit 5d3ba17.
fcolacilli
added a commit
to fcolacilli/faker
that referenced
this pull request
Feb 11, 2021
This reverts commit 5d3ba17.
This was referenced Mar 12, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added translations and tests for Spanish from Argentina.