add binary number faker #2166
Merged
add binary number faker #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielbaldao
force-pushed
the
origin/add-binary-numbers
branch
3 times, most recently
from
ffe3ebe
to
0d9f6cf
Compare
tjozwik
reviewed
Oct 20, 2020
sunny
reviewed
Oct 20, 2020
gabrielbaldao
force-pushed
the
origin/add-binary-numbers
branch
from
6fcde81
to
b1fa825
Compare
Zeragamba
suggested changes
Oct 26, 2020
gabrielbaldao
force-pushed
the
origin/add-binary-numbers
branch
2 times, most recently
from
a7bac0d
to
53b0732
Compare
|
I'm having problems with rubocop in another files, what should I do? Can I open another PR to fix this problem? |
Closed
|
@gabrielbaldao yes sure |
|
@vbrazo I think already was fixed, so I will do the rebase and push again |
gabrielbaldao
force-pushed
the
origin/add-binary-numbers
branch
from
53b0732
to
a4b74e6
Compare
vbrazo
approved these changes
Mar 7, 2021
This was referenced Mar 12, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add method to generate binary numbers