Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to stylistic eslint plugin #3068

Closed
ST-DDT opened this issue Aug 20, 2024 · 1 comment · Fixed by #3069
Closed

Switching to stylistic eslint plugin #3068

ST-DDT opened this issue Aug 20, 2024 · 1 comment · Fixed by #3069
Assignees
Labels
c: infra Changes to our infrastructure or project setup good first issue Good for newcomers p: 1-normal Nothing urgent
Milestone

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Aug 20, 2024

As typescript-eslint v8 removes some rules we are using in favor of https://eslint.style/, we want to implement e.g. @stylistic/eslint-plugin-ts so we can still benefit from rules like padding-line-between-statements

This needs to be done, before we can merge #3064, so we don't loose the checks for these rules.

This issue was created out of a thread over in #3064:

**todo (blocking):** before simply removing this lint rule, we need to add https://eslint.style/rules/ts/padding-line-between-statements

Originally posted by @Shinigami92 in #3064 (comment)

In typescript-eslint v8 has been removed as it has been moved to the eslint-stylistic package.
This issues serves as a reminder to add the rule back and to unblock the dependency update: #3064

@ST-DDT ST-DDT added good first issue Good for newcomers p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Aug 20, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Aug 20, 2024
@Shinigami92
Copy link
Member

I updated the description of the issue to reflect more accurate what's going on and what is needed.

As I'm not sure if I have the time to tackle this in the upcoming days, the good first issue label is really welcome here.

@Shinigami92 Shinigami92 changed the title Add back stylistic padding-line-between-statements lint rule Switching to stylistic eslint plugin Aug 21, 2024
@Shinigami92 Shinigami92 self-assigned this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup good first issue Good for newcomers p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants