-
-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(locale): add uzbek locale (uz_UZ_latin) #2686
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2686 +/- ##
========================================
Coverage 99.57% 99.57%
========================================
Files 2846 2859 +13
Lines 248717 249642 +925
Branches 1007 1009 +2
========================================
+ Hits 247651 248591 +940
+ Misses 1037 1022 -15
Partials 29 29
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should rename uz_UZ
to uz
.
Also please run |
Uzbek language consist of latin and cyrillic alphabets. I thought we could include support for both in the future. |
For new locales i generally prefer lang_COUNTRY - as soon as you start adding addresses and phone numbers, they are typically specific for a certain country. |
Ok, if there are two variants of the locale then we should make that visible in the name as well similar to https://github.com/faker-js/faker/tree/next/src/locales/sr_RS_latin Or is there a different common disambiguator? |
so would it be better to rename it to uz_latin? I don't think there is a common disambiguator that can be used like "uz_UZ" and "uz_CY" or something like that so we could probably use uz_latin and uz_cyrillic. |
I meant more like Language_country_variant |
uz_UZ_latin Seems the most correct. Uzbek, as spoken in Uzbekistan, with Latin variant. That would allow for say in future uz_UZ_cyrillic |
Just for clarity, the Uzbek language does not have dialectic variations such as American English, British English, or Australian English. The differences in Uzbek primarily lie within the alphabet utilized. Historically, we used the Cyrillic alphabet but transitioned to Latin over the past three decades, which is currently recognized as the official alphabet. Nevertheless, there remains a portion of the population, predominantly individuals over the age of 50-60, who only read in Cyrillic. The important point to note is that the grammar, words, and their meanings remain consistent regardless of the alphabet used. Given this context, I think that it might be more reasonable to use codes "uz_latin" and "uz_cyrillic" rather than associating them with specific countries, since the language does not vary from one country to another. However, I'm open to different solutions just wanted to give more context. |
Adding the country code, in addition to the alphabet variant is more about indicating that say |
@matthewmayer, @ST-DDT Is there any additional changes I have to make in order be able to merge? |
There are two things required.
|
Team Decision Please use We will extend the localization guide to include the representation We might change it in a future major version and then adjust all other locales as well. |
Done. |
Added initial locale values for person in Uzbek language.