Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update en currency list #1879

Closed
matthewmayer opened this issue Feb 27, 2023 · 0 comments · Fixed by #1880
Closed

Update en currency list #1879

matthewmayer opened this issue Feb 27, 2023 · 0 comments · Fixed by #1880
Assignees
@matthewmayer
Labels
c: locale Permutes locale definitions m: finance Something is referring to the finance module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
v8.x

Comments

@matthewmayer
Copy link
Contributor

matthewmayer commented Feb 27, 2023 •
edited
Loading

Originally posted by @matthewmayer in #1809 (comment)

i think there are a few "currencies" which could be removed

I reviewed various sources including https://en.wikipedia.org/wiki/List_of_circulating_currencies

I only reviewed the English locale
@matthewmayer matthewmayer self-assigned this Feb 27, 2023
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: locale Permutes locale definitions m: finance Something is referring to the finance module labels Feb 27, 2023
@ST-DDT ST-DDT moved this to Todo in Faker Roadmap Feb 27, 2023
@matthewmayer matthewmayer mentioned this issue Feb 27, 2023
Merged
@matthewmayer matthewmayer changed the title Update currency list Update em currency list Feb 27, 2023
@matthewmayer matthewmayer changed the title Update em currency list Update en currency list Feb 27, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Faker Roadmap Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewmayer matthewmayer

Labels
c: locale Permutes locale definitions m: finance Something is referring to the finance module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging a pull request may close this issue.

fix(currency): modernise currency list for 2023 matthewmayer/faker
2 participants
@matthewmayer @ST-DDT