Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(locale): extend Hebrew locale data #1721

Merged
merged 9 commits into from
Apr 1, 2023
Merged

feat(locale): extend Hebrew locale data #1721

merged 9 commits into from
Apr 1, 2023

Conversation

shai-shimon
Copy link
Contributor

@shai-shimon shai-shimon commented Jan 9, 2023 •
edited by ST-DDT
Loading

Added More

  1. Colors
  2. Music

@shai-shimon shai-shimon requested a review from a team as a code owner January 9, 2023 19:07
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: color Something is referring to the color module m: music Something is referring to the music module labels Jan 9, 2023
@ST-DDT ST-DDT requested a review from a team January 9, 2023 19:31
@ST-DDT ST-DDT changed the title Hebrew feat(locale): extend Hebrew locale data Jan 9, 2023
@codecov
Copy link

codecov bot commented Jan 9, 2023 •
edited
Loading

Codecov Report

Merging #1721 (1fd1914) into next (f9411c9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1721      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files        2526     2526              
  Lines      240704   240712       +8     
  Branches     1274     1272       -2     
==========================================
+ Hits       239798   239799       +1     
- Misses        882      889       +7     
  Partials       24       24
Impacted Files Coverage Δ
src/locales/he/color/human.ts 100.00% <100.00%> (ø)
src/locales/he/music/genre.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ST-DDT
Copy link
Member

ST-DDT commented Jan 9, 2023

Please fix the lint errors.

@ST-DDT ST-DDT requested a review from a team February 19, 2023 01:28
@ST-DDT ST-DDT requested review from matthewmayer, xDivisionByZerox and a team March 25, 2023 14:10
@ST-DDT ST-DDT enabled auto-merge (squash) April 1, 2023 12:48
@ST-DDT ST-DDT merged commit 54c2cf8 into faker-js:next Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@matthewmayer matthewmayer matthewmayer approved these changes

@xDivisionByZerox xDivisionByZerox Awaiting requested review from xDivisionByZerox

Assignees

@shai-shimon shai-shimon

Labels
c: locale Permutes locale definitions m: color Something is referring to the color module m: music Something is referring to the music module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.
6 participants
@shai-shimon @ST-DDT @matthewmayer @Shinigami92 @xDivisionByZerox @shai-benshimol