Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(image)!: remove lorempixel #1641

Merged
merged 5 commits into from
Dec 10, 2022
Merged

fix(image)!: remove lorempixel #1641

merged 5 commits into from
Dec 10, 2022

Conversation

Shinigami92
Copy link
Member

closes #1571

@Shinigami92 Shinigami92 added c: bug Something isn't working p: 1-normal Nothing urgent breaking change Cannot be merged when next version is not a major release m: image Something is referring to the image module deprecation A deprecation was made in the PR labels Dec 7, 2022
@Shinigami92 Shinigami92 added this to the v8.0 - Module Re-Shuffling milestone Dec 7, 2022
@Shinigami92 Shinigami92 requested a review from a team December 7, 2022 20:46
@Shinigami92 Shinigami92 requested a review from a team as a code owner December 7, 2022 20:46
@Shinigami92 Shinigami92 self-assigned this Dec 7, 2022
@Shinigami92
Copy link
Member Author

/ping @matthewmayer please let me know (and approve) if the docs are enough

@codecov
Copy link

codecov bot commented Dec 7, 2022 •
edited
Loading

Codecov Report

Merging #1641 (05ff527) into next (e4839a9) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1641      +/-   ##
==========================================
+ Coverage   99.62%   99.64%   +0.02%     
==========================================
  Files        2222     2221       -1     
  Lines      240514   240108     -406     
  Branches     1069     1053      -16     
==========================================
- Hits       239612   239260     -352     
+ Misses        881      827      -54     
  Partials       21       21
Impacted Files Coverage Δ
src/modules/image/index.ts 100.00% <ø> (ø)
src/modules/internet/user-agent.ts 90.54% <0.00%> (+6.48%) ⬆️

ST-DDT
ST-DDT previously approved these changes Dec 8, 2022
View reviewed changes
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Dec 8, 2022
@ST-DDT ST-DDT requested review from a team December 8, 2022 00:30
matthewmayer
matthewmayer requested changes Dec 8, 2022
View reviewed changes
docs/guide/upgrading.md Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 requested review from matthewmayer and ST-DDT and removed request for matthewmayer December 8, 2022 07:49
@matthewmayer
Copy link
Contributor

The title of this PR is also incorrect

@Shinigami92 Shinigami92 changed the title fix(image)!: remove lorempixum fix(image)!: remove lorempixel Dec 9, 2022
@Shinigami92
Copy link
Member Author

The title of this PR is also incorrect

Thank you @matthewmayer, your reviews are really welcome ❤️

@Shinigami92 Shinigami92 requested review from ejcheng, xDivisionByZerox and matthewmayer and removed request for matthewmayer December 10, 2022 13:25
@Shinigami92 Shinigami92 merged commit ab9fa1f into next Dec 10, 2022
@Shinigami92 Shinigami92 deleted the 1571-lorempixel-is-down branch December 10, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@ejcheng ejcheng ejcheng approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@matthewmayer matthewmayer Awaiting requested review from matthewmayer

Assignees

@Shinigami92 Shinigami92

Labels
breaking change Cannot be merged when next version is not a major release c: bug Something isn't working deprecation A deprecation was made in the PR m: image Something is referring to the image module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.

Lorempixel is down
5 participants
@Shinigami92 @matthewmayer @ST-DDT @ejcheng @xDivisionByZerox