Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken allowLeadingZeros tests #1638

Merged
merged 1 commit into from
Dec 7, 2022
Merged

fix: broken allowLeadingZeros tests #1638

merged 1 commit into from
Dec 7, 2022

Conversation

ejcheng
Copy link
Member

@ejcheng ejcheng commented Dec 7, 2022

No description provided.

@ejcheng ejcheng added c: bug Something isn't working c: test labels Dec 7, 2022
@ejcheng ejcheng added this to the v8.0 - Module Re-Shuffling milestone Dec 7, 2022
@ejcheng ejcheng requested a review from a team December 7, 2022 02:38
@ejcheng ejcheng self-assigned this Dec 7, 2022
@ejcheng ejcheng requested a review from a team as a code owner December 7, 2022 02:38
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #1638 (86a96f9) into next (c4b7ce8) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1638   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files        2222     2222           
  Lines      240434   240434           
  Branches     1064     1064           
=======================================
  Hits       239532   239532           
  Misses        881      881           
  Partials       21       21

ST-DDT
ST-DDT approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@ST-DDT ST-DDT added p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug labels Dec 7, 2022
@Shinigami92 Shinigami92 merged commit 97dbfa1 into next Dec 7, 2022
@Shinigami92 Shinigami92 deleted the fix/broke_tests branch December 7, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@ejcheng ejcheng

Labels
c: bug Something isn't working c: test p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.
3 participants
@ejcheng @ST-DDT @Shinigami92