Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(date)!: unify signatures #1534

Merged
merged 21 commits into from
Dec 1, 2022
Merged

refactor(date)!: unify signatures #1534

merged 21 commits into from
Dec 1, 2022

Conversation

Shinigami92
Copy link
Member

related to #1349 (comment)

@Shinigami92 Shinigami92 added c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: date Something is referring to the date module labels Nov 7, 2022
@Shinigami92 Shinigami92 added this to the v8.0 - Module Re-Shuffling milestone Nov 7, 2022
@Shinigami92 Shinigami92 self-assigned this Nov 7, 2022
@Shinigami92 Shinigami92 mentioned this pull request Nov 7, 2022
Merged
@Shinigami92 Shinigami92 added the s: on hold Blocked by something or frozen to avoid conflicts label Nov 7, 2022
@Shinigami92
Copy link
Member Author

Waiting on #1536 to be merged

@Shinigami92 Shinigami92 force-pushed the unify-date-signatures branch from 86b969d to 552560d Compare November 9, 2022 18:57
@codecov
Copy link

codecov bot commented Nov 9, 2022 •
edited
Loading

Codecov Report

Merging #1534 (8018653) into next (c78cc37) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff            @@
##             next    #1534    +/-   ##
========================================
  Coverage   99.64%   99.64%            
========================================
  Files        2221     2221            
  Lines      239065   239458   +393     
  Branches     1045     1047     +2     
========================================
+ Hits       238209   238602   +393     
  Misses        835      835            
  Partials       21       21
Impacted Files Coverage Δ
src/modules/date/index.ts 99.59% <100.00%> (+0.45%) ⬆️
src/modules/git/index.ts 100.00% <100.00%> (ø)

@Shinigami92 Shinigami92 removed the s: on hold Blocked by something or frozen to avoid conflicts label Nov 9, 2022
@Shinigami92
Copy link
Member Author

Tests running green without touching them ✔️

Will now add the new test cases 👍

@Shinigami92 Shinigami92 marked this pull request as ready for review November 9, 2022 20:46
@Shinigami92 Shinigami92 requested a review from a team as a code owner November 9, 2022 20:46
@Shinigami92 Shinigami92 requested a review from a team November 9, 2022 20:46
ST-DDT
ST-DDT reviewed Nov 9, 2022
View reviewed changes
test/date.spec.ts Outdated Show resolved Hide resolved
test/date.spec.ts Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 requested a review from ST-DDT November 10, 2022 07:59
@ST-DDT
Copy link
Member

ST-DDT commented Nov 26, 2022

Does this need to be mentioned in the upgrading docs?

@Shinigami92 Shinigami92 merged commit 0cec571 into next Dec 1, 2022
@Shinigami92 Shinigami92 deleted the unify-date-signatures branch December 1, 2022 08:40
@matthewmayer matthewmayer mentioned this pull request Mar 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejcheng ejcheng ejcheng approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox Awaiting requested review from xDivisionByZerox

Assignees

@Shinigami92 Shinigami92

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: date Something is referring to the date module
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.
3 participants
@Shinigami92 @ST-DDT @ejcheng