Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All changes missing Kevin's sink changes #1

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Conversation

faisalaltell12
Copy link
Collaborator

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

@faisalaltell12 faisalaltell12 changed the title add changes All changes missing Kevin's sink changes Jan 24, 2023
Copy link

@anniruddh anniruddh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor fixes required, will need to backport to Share repo as well.

@faisalaltell
Copy link
Owner

faisalaltell commented Jan 24, 2023

This is just a starting point, for any other improvements feel free to create a PR into the main branch.

@faisalaltell faisalaltell merged commit 03b69d8 into main Jan 24, 2023
Copy link

@anniruddh anniruddh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove /v2 from all routes in spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants