segfault on login

[jimdigriz]

The following commit 09ee629 causes ly to segfault when logging in:

alex@hanzawa:~/src/ly$ gdb bin/ly ~/core.1167 
GNU gdb (Debian 12.1-3) 12.1
[snipped]
Core was generated by `/usr/bin/ly'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  auth (desktop=0x7fffbada6fe0, login=0x7fffbada6fb0, password=0x7fffbada6f80, buf=0x7fffbada6ed0)
    at src/login.c:508
508	   env_xdg_session(desktop->display_server[desktop->cur]);
(gdb) where
#0  auth (desktop=0x7fffbada6fe0, login=0x7fffbada6fb0, password=0x7fffbada6f80, buf=0x7fffbada6ed0)
    at src/login.c:508
#1  0x0000557ed2b2df51 in main (argc=1, argv=0x7fffbada7248) at src/main.c:268
(gdb) p *desktop
$1 = {list = 0x557ed2b72ba0, list_simple = 0x557ed2b72bc0, cmd = 0x557ed2b72be0, 
  display_server = 0x557ed2b70002, cur = 2, len = 3, visible_len = 34, x = 227, y = 66}
(gdb) p desktop->display_server[desktop->cur]
Cannot access memory at address 0x557ed2b7000a
(gdb) p desktop->display_server[0]
Cannot access memory at address 0x557ed2b70002
(gdb) p desktop->display_server[1]
Cannot access memory at address 0x557ed2b70006
(gdb) p desktop->display_server[2]
Cannot access memory at address 0x557ed2b7000a
(gdb) p desktop->display_server[3]
Cannot access memory at address 0x557ed2b7000e
(gdb) 

Reverting the commit resolves the problem for me.

Let me know if you need any more information.

[AnErrupTion]

That's the result of my bad C programming :)

Anyway, I'll look at it soon!