Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom inputs #184

Closed
tcbegley opened this issue Apr 19, 2019 · 1 comment
Closed

Support custom inputs #184

tcbegley opened this issue Apr 19, 2019 · 1 comment

Comments

@tcbegley
Copy link
Collaborator

Bootstrap and reactstrap have custom input components, see for example the reactstrap documentation. These are inputs that don't use the native browser form elements like radio buttons, but instead render custom elements using CSS.

In our case, it would be most relevant to Checklist, RadioItems, Checkbox and RadioButton. The file upload and select dropdown we don't really support anyway.

In the case of the Check* components, we can also support the toggle style.

There's a few things I think to be decided:

  • Do we make additional components for this, or add a prop custom to the existing components that can be used to choose which underlying component to use. If the latter, what should the default be?
  • The CustomInput component in reactstrap needs id to be specified to work. Since this would have to be the case anyway when using the component in a callback it will mostly not be a problem, but it should fail gracefully if for some reason id is not set. If we decide to support CustomInput through existing components, we could fall back on native HTML elements if id is not set, which might be the best solution.
@tcbegley
Copy link
Collaborator Author

Resolved by #238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant