From 6e10bd21ac6fc878657b24684723ccd05e41d385 Mon Sep 17 00:00:00 2001
From: dan_the_3rd <43445237+danthe3rd@users.noreply.github.com>
Date: Wed, 20 Nov 2024 13:01:55 +0000
Subject: [PATCH] Remove build of conda binaries, as PyTorch no longer
 publishes on conda (fairinternal/xformers#1258)

__original_commit__ = fairinternal/xformers@5f58a7979441810cfb493ea2c0d04c3bbf7e79af
---
 .../compute_wheel_version.py                  |   0
 .github/workflows/conda.yml                   | 155 ---------------
 .github/workflows/rocm_build.yml              |   2 +-
 .github/workflows/wheels.yml                  |   2 +-
 .github/workflows/wheels_build.yml            |   2 +-
 .github/workflows/wheels_upload_pip.yml       |   2 +-
 CHANGELOG.md                                  |   4 +
 README.md                                     |  14 +-
 packaging/build_conda.py                      | 182 ------------------
 packaging/xformers/meta.yaml                  |  44 -----
 10 files changed, 9 insertions(+), 398 deletions(-)
 rename {packaging => .github}/compute_wheel_version.py (100%)
 delete mode 100644 .github/workflows/conda.yml
 delete mode 100644 packaging/build_conda.py
 delete mode 100644 packaging/xformers/meta.yaml

diff --git a/packaging/compute_wheel_version.py b/.github/compute_wheel_version.py
similarity index 100%
rename from packaging/compute_wheel_version.py
rename to .github/compute_wheel_version.py
diff --git a/.github/workflows/conda.yml b/.github/workflows/conda.yml
deleted file mode 100644
index 5f4dc77fbc..0000000000
--- a/.github/workflows/conda.yml
+++ /dev/null
@@ -1,155 +0,0 @@
-name: conda
-
-on:
-  workflow_dispatch: {}
-  pull_request:
-    paths:
-      - "packaging/**"
-      - ".github/workflows/conda.yml"
-      - "setup.py"
-      - "requirements*.txt"
-  push:
-    branches:
-      - main
-    tags:
-      - "v[0-9]+*"
-
-# this yaml file can be cleaned up using yaml anchors, but they're not supported in github actions yet
-# https://github.com/actions/runner/issues/1182
-
-env:
-  MAX_JOBS: 3  # Avoids OOMs
-  XFORMERS_BUILD_TYPE: "Release"
-  XFORMERS_PACKAGE_FROM: "conda-${{ github.ref_name }}"
-  # https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
-  ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: "true"
-
-jobs:
-  build:
-    strategy:
-      fail-fast: false
-      matrix:
-        python:
-          - "3.10"
-          - "3.11"
-          - "3.12"
-        config:
-          - torch_version: "2.5.1"
-            torch_channel: "pytorch"
-            cuda_version: "12.1.0"
-            cuda_dep_runtime: ">=12.0,<13.0"
-            cuda_short_version: "121"
-
-          - torch_version: "2.5.1"
-            torch_channel: "pytorch"
-            cuda_version: "11.8.0"
-            cuda_dep_runtime: ">=11.7,<11.9"
-            cuda_short_version: "118"
-
-    name: py${{ matrix.python }}-torch${{ matrix.config.torch_version }}-cu${{ matrix.config.cuda_version }}
-    runs-on: 8-core-ubuntu  # 32GB RAM, 8 vCPUs
-
-    container:
-      image: quay.io/pypa/manylinux_2_28_x86_64
-    env:
-      # you need at least cuda 5.0 for some of the stuff compiled here.
-      TORCH_CUDA_ARCH_LIST: '6.0+PTX 7.0 7.5 8.0+PTX'
-
-    timeout-minutes: 360
-    defaults:
-      run:
-        shell: bash
-    steps:
-      - if: fromJSON(matrix.config.cuda_short_version) >= 120
-        run: |
-          echo "TORCH_CUDA_ARCH_LIST=$TORCH_CUDA_ARCH_LIST 9.0a" >> ${GITHUB_ENV}
-      - name: System info
-        run: |
-          pwd
-          df -h
-          ldd --version
-          echo "Memory and swap:"
-          free -h
-          echo
-          swapon --show
-      - name: Set tag = 'dev'
-        run: echo "XFORMERS_CONDA_TAG=dev" >> $GITHUB_ENV
-      - name: Set tag = 'main'
-        if: startsWith(github.ref, 'refs/tags/v')
-        run: echo "XFORMERS_CONDA_TAG=main" >> $GITHUB_ENV
-      - run: echo "${XFORMERS_CONDA_TAG}"
-      - name: Recursive checkout
-        uses: actions/checkout@v3
-        with:
-          submodules: recursive
-          path: "."
-          fetch-depth: 0 # for tags
-      - name: Install micromamba
-        shell: bash -l {0}
-        run: |
-          set -ex
-          curl -Ls https://micro.mamba.pm/api/micromamba/linux-64/latest | tar -xvj bin/micromamba
-          echo "eval \"\$($(pwd)/bin/micromamba shell hook --shell bash)\"" >> ~/.profile
-      - run: |
-          micromamba config set channel_priority strict
-          micromamba create --name env -y anaconda-client conda-build python=${{ matrix.python }} -c anaconda
-        shell: bash -l {0}
-      - name: Activate environment
-        shell: bash -l {0}
-        run: |
-          echo "micromamba activate env" >> ~/.profile
-          echo "==== .profile ====="
-          cat ~/.profile
-      - run: which python; which gcc
-        shell: bash -l {0}
-      - name: Setup Runner
-        uses: ./.github/actions/setup-build-cuda
-        with:
-          toolkit_type: cuda
-          toolkit_short_version: ${{ matrix.config.cuda_short_version }}
-          python: ${{ matrix.python }}
-      - name: Define version
-        shell: bash -l {0}
-        env:
-          VERSION_SOURCE: ${{ github.ref_type == 'tag' && 'tag' || 'dev'  }}
-        run: |
-          set -Eeuo pipefail
-          git config --global --add safe.directory "$(pwd)"
-          git rev-parse --short HEAD
-          python -m pip install packaging
-          version=`python packaging/compute_wheel_version.py --source $VERSION_SOURCE`
-          echo "BUILD_VERSION=$version" >> ${GITHUB_ENV}
-          cat ${GITHUB_ENV}
-      - name: Build & store/upload
-        shell: bash -l {0}
-        env:
-          # NOTE: Ternary operator: ${{ cond && 'trueVal' || 'falseVal' }}
-          STORE_PT_PACKAGE: ${{ matrix.config.torch_channel != 'pytorch' && '--store-pytorch-package' || '' }}
-        run: |
-          anaconda upload --help
-          python packaging/build_conda.py \
-          --cuda ${{ matrix.config.cuda_version }} \
-          --python ${{ matrix.python }} \
-          --pytorch ${{ matrix.config.torch_version }} \
-          --pytorch-channel ${{ matrix.config.torch_channel }} \
-          --cuda-dep-runtime "${{ matrix.config.cuda_dep_runtime }}" \
-          --store $STORE_PT_PACKAGE
-      - name: Upload
-        shell: bash -l {0}
-        if: github.repository == 'facebookresearch/xformers' && github.event_name != 'pull_request' && matrix.config.torch_channel == 'pytorch'
-        env:
-          ANACONDA_API_TOKEN: ${{ secrets.ANACONDA_API_TOKEN }}
-        run: |
-          # This might fail, let's retry it multiple times
-          for i in {1..20}
-          do
-              [[ $i != 1 ]] && sleep 15
-              echo "Attempt $i"
-              anaconda upload --user xformers --label ${XFORMERS_CONDA_TAG} packages/* && break
-          done
-      - uses: actions/upload-artifact@v4
-        if: success() || failure()
-        with:
-          name: linux-py${{ matrix.python }}-torch${{ matrix.config.torch_version }}-cu${{ matrix.config.cuda_short_version }}
-          path: packages
-# Note: it might be helpful to have additional steps that test if the built wheels actually work
diff --git a/.github/workflows/rocm_build.yml b/.github/workflows/rocm_build.yml
index 8d3751c6f1..8c8bd9b081 100644
--- a/.github/workflows/rocm_build.yml
+++ b/.github/workflows/rocm_build.yml
@@ -6,7 +6,7 @@ on:
       - develop
   pull_request:
     paths:
-      - "packaging/compute_wheel_version.sh"
+      - ".github/compute_wheel_version.py"
       - ".github/workflows/rocm_build.yml"
       - ".github/workflows/wheels_build.yml"
       - "setup.py"
diff --git a/.github/workflows/wheels.yml b/.github/workflows/wheels.yml
index e1ba745b0f..db6ba6572a 100644
--- a/.github/workflows/wheels.yml
+++ b/.github/workflows/wheels.yml
@@ -3,7 +3,7 @@ name: wheels
 on:
   pull_request:
     paths:
-      - "packaging/compute_wheel_version.sh"
+      - ".github/compute_wheel_version.py"
       - ".github/workflows/wheel*"
       - ".github/actions/setup-build-cuda/action.yml"
       - "setup.py"
diff --git a/.github/workflows/wheels_build.yml b/.github/workflows/wheels_build.yml
index 13ad3c7713..4e9e1ccd50 100644
--- a/.github/workflows/wheels_build.yml
+++ b/.github/workflows/wheels_build.yml
@@ -93,7 +93,7 @@ jobs:
         run: |
           set -Eeuo pipefail
           git config --global --add safe.directory "*"
-          version=`python packaging/compute_wheel_version.py --source $VERSION_SOURCE`
+          version=`python .github/compute_wheel_version.py --source $VERSION_SOURCE`
           echo $version > version.txt
           echo "BUILD_VERSION=$version${{ steps.cuda_info.outputs.CUDA_VERSION_SUFFIX }}" >> ${GITHUB_ENV}
           echo "BUILD_VERSION=$version${{ steps.cuda_info.outputs.CUDA_VERSION_SUFFIX }}" >> ${GITHUB_OUTPUT}
diff --git a/.github/workflows/wheels_upload_pip.yml b/.github/workflows/wheels_upload_pip.yml
index a4a4c2a015..a46ee5017a 100644
--- a/.github/workflows/wheels_upload_pip.yml
+++ b/.github/workflows/wheels_upload_pip.yml
@@ -86,7 +86,7 @@ jobs:
         env:
           VERSION_SOURCE: ${{ github.ref_type == 'tag' && 'tag' || 'dev'  }}
         run: |
-          version=`$PY packaging/compute_wheel_version.py --source $VERSION_SOURCE`
+          version=`$PY .github/compute_wheel_version.py --source $VERSION_SOURCE`
           echo $version > version.txt
           cat version.txt
 
diff --git a/CHANGELOG.md b/CHANGELOG.md
index eafdcd4021..d48ff31e5f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.0.28.post3] - TBD
+### Removed:
+- Following PyTorch, xFormers no longer builds binaries for conda. Pip is now the only recommended way to get xFormers
+
 ## [0.0.28.post3] - 2024-10-30
 Pre-built binary wheels require PyTorch 2.5.1
 
diff --git a/README.md b/README.md
index 27b414c8de..37850ecda9 100644
--- a/README.md
+++ b/README.md
@@ -1,8 +1,5 @@
 <img src="./docs/assets/logo.png" width=800>
 
-![Install with conda](https://anaconda.org/xformers/xformers/badges/installer/conda.svg)
-![Downloads](https://anaconda.org/xformers/xformers/badges/downloads.svg)
-![License](https://anaconda.org/xformers/xformers/badges/license.svg)
 [![Open in Colab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/github/facebookresearch/xformers/blob/main/docs/source/xformers_mingpt.ipynb)
 <br/><!--
 ![PyPI](https://img.shields.io/pypi/v/xformers)
@@ -28,13 +25,6 @@ xFormers is:
 
 ## Installing xFormers
 
-* **(RECOMMENDED, linux) Install latest stable with conda**: Requires [PyTorch 2.5.1 installed with conda](https://pytorch.org/get-started/locally/)
-
-```bash
-# (python 3.10/3.11 only)
-conda install xformers -c xformers
-```
-
 * **(RECOMMENDED, linux & win) Install latest stable with pip**: Requires [PyTorch 2.5.1](https://pytorch.org/get-started/locally/)
 
 ```bash
@@ -51,8 +41,7 @@ pip3 install -U xformers --index-url https://download.pytorch.org/whl/rocm6.1
 * **Development binaries**:
 
 ```bash
-# Use either conda or pip, same requirements as for the stable version above
-conda install xformers -c xformers/label/dev
+# Same requirements as for the stable version above
 pip install --pre -U xformers
 ```
 
@@ -108,7 +97,6 @@ python -m xformers.info
 * the version of GCC that you're using matches the current NVCC capabilities
 * the `TORCH_CUDA_ARCH_LIST` env variable is set to the architectures that you want to support. A suggested setup (slow to build but comprehensive) is `export TORCH_CUDA_ARCH_LIST="6.0;6.1;6.2;7.0;7.2;7.5;8.0;8.6"`
 * If the build from source OOMs, it's possible to reduce the parallelism of ninja with `MAX_JOBS` (eg `MAX_JOBS=2`)
-* If you encounter [`UnsatisfiableError`](https://github.com/facebookresearch/xformers/issues/390#issuecomment-1315020700) when installing with conda, make sure you have PyTorch installed in your conda environment, and that your setup (PyTorch version, cuda version, python version, OS) match [an existing binary for xFormers](https://anaconda.org/xformers/xformers/files)
 
 
 ### License
diff --git a/packaging/build_conda.py b/packaging/build_conda.py
deleted file mode 100644
index 38a76fcd09..0000000000
--- a/packaging/build_conda.py
+++ /dev/null
@@ -1,182 +0,0 @@
-# Copyright (c) Facebook, Inc. and its affiliates. All rights reserved.
-#
-# This source code is licensed under the BSD license found in the
-# LICENSE file in the root directory of this source tree.
-import argparse
-import os
-import shutil
-import subprocess
-from dataclasses import dataclass
-from pathlib import Path
-from typing import List
-
-THIS_PATH = Path(__file__).resolve()
-SOURCE_ROOT_DIR = THIS_PATH.parents[1]
-
-
-@dataclass
-class Build:
-    """
-    Represents one configuration of a build, i.e.
-    a set of versions of dependent libraries.
-
-    Members:
-        conda_always_copy: avoids hard linking which can behave weirdly.
-        conda_debug: get added information about package search
-        conda_dirty: see intermediate files after build
-        build_inside_tree: output in build/ not ../build
-        is_release: whether this is an official versioned release
-    """
-
-    python_version: str
-    pytorch_version: str
-    pytorch_channel: str
-    cuda_version: str
-    cuda_dep_runtime: str
-
-    conda_always_copy: bool = True
-    conda_debug: bool = False
-    conda_dirty: bool = False
-    build_inside_tree: bool = False
-
-    def _set_env_for_build(self) -> None:
-        """
-        NOTE: Variables set here won't be visible in `setup.py`
-        UNLESS they are also specified in meta.yaml
-        """
-        assert (
-            "BUILD_VERSION" in os.environ
-        ), "BUILD_VERSION must be set as env variable"
-        tag = subprocess.check_output(
-            ["git", "rev-parse", "--short", "HEAD"], text=True
-        ).strip()
-        os.environ["GIT_TAG"] = tag
-        os.environ["PYTORCH_VERSION"] = self.pytorch_version
-        os.environ["CU_VERSION"] = self.cuda_version
-        os.environ["SOURCE_ROOT_DIR"] = str(SOURCE_ROOT_DIR)
-
-        # At build time, the same major/minor (otherwise we might get a CPU pytorch ...)
-        cuda_constraint_build = "=" + ".".join(self.cuda_version.split(".")[:2])
-        pytorch_version_tuple = tuple(
-            int(v) for v in self.pytorch_version.split(".")[:2]
-        )
-        if pytorch_version_tuple < (1, 13):
-            os.environ[
-                "CONDA_CUDA_CONSTRAINT_BUILD"
-            ] = f"cudatoolkit{cuda_constraint_build}"
-            os.environ[
-                "CONDA_CUDA_CONSTRAINT_RUN"
-            ] = f"cudatoolkit{self.cuda_dep_runtime}"
-        else:
-            os.environ[
-                "CONDA_CUDA_CONSTRAINT_BUILD"
-            ] = f"pytorch-cuda{cuda_constraint_build}"
-            os.environ[
-                "CONDA_CUDA_CONSTRAINT_RUN"
-            ] = f"pytorch-cuda{self.cuda_dep_runtime}"
-
-        if self.conda_always_copy:
-            os.environ["CONDA_ALWAYS_COPY"] = "true"
-
-    def _get_build_args(self) -> List[str]:
-        args = [
-            "conda",
-            "build",
-            "-c",
-            self.pytorch_channel,
-            "-c",
-            "nvidia",
-            "--python",
-            self.python_version,
-            "--no-anaconda-upload",
-        ]
-        if self.conda_debug:
-            args += ["--debug"]
-        if self.conda_dirty:
-            args += ["--dirty"]
-        if not self.build_inside_tree:
-            args += ["--croot", "../build"]
-        return args + ["packaging/xformers"]
-
-    def do_build(self) -> None:
-        self._set_env_for_build()
-        args = self._get_build_args()
-        print(args)
-        subprocess.check_call(args)
-
-    def move_artifacts_to_store(self, store_pytorch_package: bool) -> None:
-        """
-        Run after a build to move the built package, and, if using nightly, the
-        used PyTorch package, to a location where they will be recognized
-        as build artifacts.
-        """
-        print("moving artifacts")
-        assert not self.build_inside_tree
-        artifacts = Path("packages")
-        artifacts.mkdir(exist_ok=True)
-        for filename in Path("../build/linux-64").resolve().glob("*.tar.bz2"):
-            print("moving", filename, "to", artifacts)
-            shutil.move(filename, artifacts)
-        if store_pytorch_package:
-            for filename in Path("/opt/conda/pkgs").glob("pytorch-[12].*.tar.bz2"):
-                print("moving", filename, "to", artifacts)
-                shutil.move(filename, artifacts)
-
-
-if __name__ == "__main__":
-    parser = argparse.ArgumentParser(description="Build the conda package.")
-    parser.add_argument(
-        "--python", metavar="3.X", required=True, help="python version e.g. 3.10"
-    )
-    parser.add_argument(
-        "--cuda-dep-runtime", metavar="1X.Y", required=True, help="eg '>=11.7,<11.9"
-    )
-    parser.add_argument(
-        "--cuda", metavar="1X.Y", required=True, help="cuda version e.g. 11.3"
-    )
-    parser.add_argument(
-        "--pytorch", metavar="1.Y.Z", required=True, help="PyTorch version e.g. 1.11.0"
-    )
-    parser.add_argument(
-        "--build-inside-tree",
-        action="store_true",
-        help="Build in build/ instead of ../build/",
-    )
-    parser.add_argument(
-        "--store",
-        action="store_true",
-        help="position artifact to store",
-    )
-    parser.add_argument(
-        "--store-pytorch-package",
-        action="store_true",
-        help="position artifact to store",
-    )
-    parser.add_argument(
-        "--pytorch-channel", default="pytorch", help="Use 'pytorch-nightly' for nightly"
-    )
-    args = parser.parse_args()
-
-    pkg = Build(
-        pytorch_channel=args.pytorch_channel,
-        python_version=args.python,
-        pytorch_version=args.pytorch,
-        cuda_version=args.cuda,
-        build_inside_tree=args.build_inside_tree,
-        cuda_dep_runtime=args.cuda_dep_runtime,
-    )
-
-    pkg.do_build()
-    pkg.move_artifacts_to_store(store_pytorch_package=args.store_pytorch_package)
-
-
-# python packaging/conda/build_conda.py  --cuda 11.6 --python 3.10 --pytorch 1.12.1
-# python packaging/conda/build_conda.py  --cuda 11.3 --python 3.9 --pytorch 1.12.1  # <= the dino one
-# python packaging/conda/build_conda.py  --cuda 11.6 --python 3.10 --pytorch 1.11.0
-
-# Note this does the build outside the root of the tree.
-
-# TODO:
-# - Make a local conda package cache available inside docker
-# - do we need builds for both _GLIBCXX_USE_CXX11_ABI values?
-# - how to prevent some cpu only builds of pytorch from being discovered?
diff --git a/packaging/xformers/meta.yaml b/packaging/xformers/meta.yaml
deleted file mode 100644
index c42d1a8d6c..0000000000
--- a/packaging/xformers/meta.yaml
+++ /dev/null
@@ -1,44 +0,0 @@
-package:
-  name: xformers
-  version: "{{ environ.get('BUILD_VERSION') }}"
-
-source:
- path: "{{ environ.get('SOURCE_ROOT_DIR') }}"
-
-requirements:
-  build:
-    - ninja
-    - pytorch={{ environ.get('PYTORCH_VERSION') }}
-  host:
-    # - numpy >=1.11
-    - python
-    - pytorch={{ environ.get('PYTORCH_VERSION') }}
-    - {{environ['CONDA_CUDA_CONSTRAINT_BUILD']}}
-
-  run:
-    # - numpy >=1.11
-    - python
-    - pytorch={{ environ.get('PYTORCH_VERSION') }}
-    - {{environ['CONDA_CUDA_CONSTRAINT_RUN']}}
-
-build:
-  string: py{{py}}_cu{{ environ['CU_VERSION'] }}_pyt{{ environ['PYTORCH_VERSION']}}
-  script: {{environ['PYTHON']}} setup.py install --single-version-externally-managed --record=record.txt
-  script_env:
-    - BUILD_VERSION
-    - FORCE_CUDA
-    - GIT_TAG
-    - MAX_JOBS
-    - TORCH_CUDA_ARCH_LIST
-    - XFORMERS_BUILD_TYPE
-    - XFORMERS_PACKAGE_FROM
-    - CUDA_HOME
-
-about:
-  home: https://github.com/facebookresearch/xformers
-  license: BSD
-  license_file: LICENSE
-  summary: 'Hackable and optimized Transformers building blocks, supporting a composable construction.'
-
-extra:
-  checkout: "{{ environ['GIT_TAG'] }}"