Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Distributed sampler shuffle bug #437

Closed
adrifloresm opened this issue Feb 14, 2019 · 2 comments
Closed

Distributed sampler shuffle bug #437

adrifloresm opened this issue Feb 14, 2019 · 2 comments
Labels
contributions welcome enhancement New feature or request good first issue Good for newcomers

Comments

@adrifloresm
Copy link

🐛 Bug

The initialization of the shuffle variable in the distributed shuffler is hard-coded to True.

https://github.com/facebookresearch/maskrcnn-benchmark/blob/master/maskrcnn_benchmark/data/samplers/distributed.py#L40

switch from:
self.shuffle = True

to
self.shuffle = shuffle
@fmassa
Copy link
Contributor

fmassa commented Feb 14, 2019

Great point!

Could you send a PR fixing it?

@fmassa fmassa added enhancement New feature or request good first issue Good for newcomers contributions welcome labels Feb 14, 2019
@hpandeycodeit hpandeycodeit mentioned this issue Feb 14, 2019
Merged
@fmassa
Copy link
Contributor

fmassa commented Feb 15, 2019

Fixed via #438

@fmassa fmassa closed this as completed Feb 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
contributions welcome enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fmassa @adrifloresm