Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable CI for Windows #1056

Closed
omry opened this issue Oct 13, 2020 · 2 comments
Closed

Re-enable CI for Windows #1056

omry opened this issue Oct 13, 2020 · 2 comments
Assignees
@jieru-hu
Labels
maintenance Project maintenance
Milestone
Hydra 1.1.0

Comments

@omry
Copy link
Collaborator

omry commented Oct 13, 2020 •
edited
Loading

Windows CI started to fail recently with nox detecting an invalid Python version (Interestingly on Python 3.7 and 3.8 in Conda, and not 3.6).

For now I disabled these those Python versions on Windows and opened this to try to get some help.

We should fix and re-enable these CI modes.

Disabled in #1055.
@omry omry added this to the 1.1.0 milestone Oct 13, 2020
@omry omry added the maintenance Project maintenance label Oct 13, 2020
@omry
Copy link
Collaborator Author

omry commented Oct 20, 2020

This is a new problem with virtualenv and conda on Windows.
One of the comments I found suggests that downgrading to virtualenv==20.0.33 is the workaround until this gets fixed between virtualenv and conda.

Relevant upstream issues:

@omry omry mentioned this issue Dec 12, 2020
Merged
@jieru-hu jieru-hu self-assigned this Feb 19, 2021
@omry
Copy link
Collaborator Author

omry commented Apr 1, 2021

As far as I can tell, CI is working on Windows now.

@omry omry closed this as completed Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jieru-hu jieru-hu

Labels
maintenance Project maintenance
Projects
None yet
Milestone
Hydra 1.1.0
Development

No branches or pull requests
2 participants
@omry @jieru-hu