Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Content Snapshot Code Missing #23

Open
waytehsu opened this issue Mar 18, 2021 · 1 comment
Open

Content Snapshot Code Missing #23

waytehsu opened this issue Mar 18, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@waytehsu
Copy link

if self.config.sample_row_num < row_num:
sampled_row_ids = sorted(random.sample(row_ids, k=self.config.sample_row_num))

Thanks for open-sourcing the project. In the paper, you describe Content Snapshot as using n-gram to select the top K-rows. Do you have the code of that part in the repo? I see in your current implementation, you simply randomly choose K-rows for training instead, as shown in the snippet above.

@pcyin pcyin self-assigned this Jun 10, 2021
@pcyin pcyin added the bug Something isn't working label Jun 10, 2021
@pafitis
Copy link

pafitis commented Sep 18, 2021

Hi — thanks for publishing this!

I was wondering if you are planning to add the content snapshot code.

Thanks for your time; very cool stuff!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants