Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Presto url_extract_* functions to use RE2 instead of boost::regexp #7885

Open
kgpai opened this issue Dec 5, 2023 · 0 comments
Open

Enhance Presto url_extract_* functions to use RE2 instead of boost::regexp #7885

kgpai opened this issue Dec 5, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@kgpai
Copy link
Contributor

kgpai commented Dec 5, 2023

Description

Currently the presto url_extract_* functions use boost::regexp which are slower than RE2 . Some research online says that the speed up is close to 10x. We already use RE2 in velox , so we will not be adding a new dependency.
@kgpai kgpai added the enhancement New feature or request label Dec 5, 2023
@kgpai kgpai changed the title Move Presto url_extract_* functions to use RE2 instead of boost::regexp Fix Presto url_extract_* functions to use RE2 instead of boost::regexp Dec 5, 2023
@kgpai kgpai changed the title Fix Presto url_extract_* functions to use RE2 instead of boost::regexp Enhance Presto url_extract_* functions to use RE2 instead of boost::regexp Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kgpai