From ccb4885e930f3eab22e69dbeef2ee633198072cd Mon Sep 17 00:00:00 2001
From: Deepak Majeti <deepak.majeti@ibm.com>
Date: Tue, 17 Dec 2024 13:46:26 -0500
Subject: [PATCH] build: Do not enable all components when testing is enabled

---
 .github/workflows/linux-build-base.yml |  3 ++-
 CMakeLists.txt                         | 13 -------------
 2 files changed, 2 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/linux-build-base.yml b/.github/workflows/linux-build-base.yml
index 4d8218f2e53f..45c41a572702 100644
--- a/.github/workflows/linux-build-base.yml
+++ b/.github/workflows/linux-build-base.yml
@@ -86,6 +86,7 @@ jobs:
         run: |
           EXTRA_CMAKE_FLAGS=(
             "-DVELOX_ENABLE_BENCHMARKS=ON"
+            "-DVELOX_ENABLE_EXAMPLES=ON"
             "-DVELOX_ENABLE_ARROW=ON"
             "-DVELOX_ENABLE_PARQUET=ON"
             "-DVELOX_ENABLE_HDFS=ON"
@@ -160,7 +161,7 @@ jobs:
           VELOX_DEPENDENCY_SOURCE: BUNDLED
           ICU_SOURCE: SYSTEM
           MAKEFLAGS: "NUM_THREADS=8 MAX_HIGH_MEM_JOBS=4 MAX_LINK_JOBS=3"
-          EXTRA_CMAKE_FLAGS: "-DVELOX_ENABLE_ARROW=ON -DVELOX_ENABLE_PARQUET=ON"
+          EXTRA_CMAKE_FLAGS: "-DVELOX_ENABLE_ARROW=ON -DVELOX_ENABLE_PARQUET=ON -DVELOX_ENABLE_EXAMPLES=ON"
         run: |
           if [[ "${USE_CLANG}" = "true" ]]; then export CC=/usr/bin/clang-15; export CXX=/usr/bin/clang++-15; fi
           make debug
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 34ac58b7d7e6..5ae50786209b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -173,19 +173,6 @@ if(${VELOX_BUILD_MINIMAL} OR ${VELOX_BUILD_MINIMAL_WITH_DWIO})
   set(VELOX_ENABLE_SUBSTRAIT OFF)
 endif()
 
-if(${VELOX_BUILD_TESTING})
-  # Enable all components to build testing binaries
-  set(VELOX_ENABLE_PRESTO_FUNCTIONS ON)
-  set(VELOX_ENABLE_EXPRESSION ON)
-  set(VELOX_ENABLE_EXEC ON)
-  set(VELOX_ENABLE_AGGREGATES ON)
-  set(VELOX_ENABLE_HIVE_CONNECTOR ON)
-  set(VELOX_ENABLE_TPCH_CONNECTOR ON)
-  set(VELOX_ENABLE_SPARK_FUNCTIONS ON)
-  set(VELOX_ENABLE_EXAMPLES ON)
-  set(VELOX_ENABLE_PARQUET ON)
-endif()
-
 if(${VELOX_ENABLE_BENCHMARKS})
   set(VELOX_ENABLE_BENCHMARKS_BASIC ON)
 endif()