From a6daaeb786928da3ac26b27e2607176cffc191fb Mon Sep 17 00:00:00 2001 From: Alex Hornby Date: Fri, 6 Oct 2023 21:20:06 -0700 Subject: [PATCH] save some CI diskspace, use ubuntu 20.04 and later libgit2 (#6925) Summary: Pull Request resolved: https://github.com/facebookincubator/velox/pull/6925 save some CI diskspace, use ubuntu 20.04 and later libgit2 Save some time and diskspace in CI builds for github by using the system libraries X-link: https://github.com/facebook/sapling/pull/693 Test Plan: Install deps and build locally with ``` sudo ./build/fbcode_builder/getdeps.py --allow-system-packages install-system-deps --recursive eden ... ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden ``` before: we build libgit2 from source after: we use the system library --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/sapling/pull/693). * __->__ https://github.com/facebook/sapling/issues/693 * https://github.com/facebook/sapling/issues/696 * https://github.com/facebook/sapling/issues/692 * https://github.com/facebook/sapling/issues/691 * https://github.com/facebook/sapling/issues/682 * https://github.com/facebook/sapling/issues/689 * https://github.com/facebook/sapling/issues/697 * https://github.com/facebook/sapling/issues/706 * https://github.com/facebook/sapling/issues/730 Reviewed By: quark-zju, xavierd Differential Revision: D49874384 Pulled By: genevievehelsel fbshipit-source-id: 09c01eec69446c9bfa95861d9e71617b44b44fce --- build/fbcode_builder/manifests/libgit2 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/build/fbcode_builder/manifests/libgit2 b/build/fbcode_builder/manifests/libgit2 index 27279d513d78..33e6b506f98f 100644 --- a/build/fbcode_builder/manifests/libgit2 +++ b/build/fbcode_builder/manifests/libgit2 @@ -10,8 +10,8 @@ libgit2-devel # Ubuntu 18.04 libgit2 has clash with libcurl4-openssl-dev as it depends on # libcurl4-gnutls-dev. Should be ok from 20.04 again # There is a description at https://github.com/r-hub/sysreqsdb/issues/77 -# [debs] -# libgit2-dev +[debs.not(all(distro=ubuntu,distro_vers="18.04"))] +libgit2-dev [download] url = https://github.com/libgit2/libgit2/archive/v0.28.1.tar.gz