Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

Respect python_requires for test running #45

Open
cooperlees opened this issue May 21, 2019 · 0 comments
Open

Respect python_requires for test running #45

cooperlees opened this issue May 21, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@cooperlees
Copy link
Contributor

cooperlees commented May 21, 2019

How is ptr not doing what you expect?

Today, ptr will not look at the python3 version and only run the the test suite if python_requires passes.

What is your suggestion to make this better?

Have the ast parser pull out python_requires if it exists (from setup.py + setup.cfg) and then skip a test suite if the requirement is not met.

  • Try and look for upstream libraries to either vendor or include as deps for ptr to parse python_requires.
  • This should be able to be disabled in the repo .ptrconfig

How can a developer reproduce this?

Run ptr on a Python 3.7 only project (stated via python_requires) with python3.6 ptr.

@cooperlees cooperlees added the enhancement New feature or request label May 21, 2019
@cooperlees cooperlees self-assigned this May 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant