Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script name to open chrome #831

Merged
merged 1 commit into from
Oct 3, 2016
Merged

Fix script name to open chrome #831

merged 1 commit into from
Oct 3, 2016

Conversation

unixdev
Copy link
Contributor

@unixdev unixdev commented Oct 3, 2016

A previous commit renamed the apple script to open chrome from
chrome.applescript to openChrome.applescript. That created
a minor bug. Even when chrome was open with the client app,
npm start would open the client app in a new Safari tab on
macOS instead of re-using the open tab in chrome.

A previous commit renamed the apple script to open chrome from
`chrome.applescript` to `openChrome.applescript`. That created
a minor bug. Even when chrome was open with the client app,
`npm start` would open the client app in a new Safari tab on
macOS instead of re-using the open tab in chrome.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon gaearon merged commit 856001f into facebook:master Oct 3, 2016
@gaearon
Copy link
Contributor

gaearon commented Oct 3, 2016

Ah, good catch. Thanks!

@gaearon gaearon added this to the 0.7.0 milestone Oct 3, 2016
kitze added a commit to kitze/custom-react-scripts that referenced this pull request Oct 6, 2016
…react-app

# By Dan Abramov (2) and others
# Via Dan Abramov
* 'master' of https://github.com/facebookincubator/create-react-app:
  Correct a comment mistype in webpack production config (facebook#855)
  load setupTests file at setupTestFramework stage (facebook#846)
  Spell check (facebook#845)
  Tweak readme
  Update instructions on publishing to GitHub pages (facebook#841)
  Make webpackHotDevClient support webpack 2 too (facebook#840)
  Tweak eject output
  Promote "React must be in scope" to be an error (facebook#822)
  Fix script name to open chrome (facebook#831)
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
A previous commit renamed the apple script to open chrome from
`chrome.applescript` to `openChrome.applescript`. That created
a minor bug. Even when chrome was open with the client app,
`npm start` would open the client app in a new Safari tab on
macOS instead of re-using the open tab in chrome.
maltestenzel pushed a commit to maltestenzel/custom-react-scripts that referenced this pull request Mar 7, 2018
…react-app

# By Dan Abramov (2) and others
# Via Dan Abramov
* 'master' of https://github.com/facebookincubator/create-react-app:
  Correct a comment mistype in webpack production config (facebook#855)
  load setupTests file at setupTestFramework stage (facebook#846)
  Spell check (facebook#845)
  Tweak readme
  Update instructions on publishing to GitHub pages (facebook#841)
  Make webpackHotDevClient support webpack 2 too (facebook#840)
  Tweak eject output
  Promote "React must be in scope" to be an error (facebook#822)
  Fix script name to open chrome (facebook#831)
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants