use safer/more aesthetic syntax for setting environment variables on Windows #3533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Timer any thoughts on this? |
|
I like this. Thanks! |
Merged
This was referenced Feb 2, 2018
Pavek
pushed a commit
to Pavek/create-react-app
that referenced
this pull request
Jul 10, 2018
* use safer/more aesthetic syntax * fix typo
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Aug 14, 2018
* use safer/more aesthetic syntax * fix typo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Cleaned up version of #3530)
Documentation update to fix a maddeningly easy oversite for Windows users. The
SETcommand allows for wrapping the variable assignment expression with double quotes. Using this method negates the need to smash two commands together with the&&operator as currently documented.