Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Subresource Integrity support #1176

Merged
merged 2 commits into from
Dec 6, 2016
Merged

Add Subresource Integrity support #1176

merged 2 commits into from
Dec 6, 2016

Conversation

XVincentX
Copy link

@XVincentX XVincentX commented Dec 6, 2016 •
edited
Loading

This pull request will add to create-react-app the ability to inject into the final html page the integrity hashes required to take advantage of Subresource Integrity (when the browser supports it)

@XVincentX XVincentX mentioned this pull request Dec 6, 2016
Closed
@gaearon
Copy link
Contributor

gaearon commented Dec 6, 2016

Have you verified it works?

@XVincentX
Copy link
Author

Yes it does on my machine - I'm trying to figure out if I can write a test for that.
Unfortunately it's the first time I dig into this repository so - it might require a bit.

@XVincentX
Copy link
Author

This is the result I'm getting on a production build.

image

@gaearon
Copy link
Contributor

gaearon commented Dec 6, 2016

No worries about the test—we don't have anything other than smoke checks at the moment.
Looks good.

@gaearon gaearon added this to the 0.8.2 milestone Dec 6, 2016
@gaearon
Copy link
Contributor

gaearon commented Dec 6, 2016

LGTM

@gaearon gaearon merged commit 11cd813 into facebook:master Dec 6, 2016
@gaearon
Copy link
Contributor

gaearon commented Dec 6, 2016

Thank you!

@XVincentX
Copy link
Author

That was fast! Thanks a lot, I'm glad I contributed.

@XVincentX XVincentX mentioned this pull request Dec 6, 2016
Merged
mofelee added a commit to xiaohu-developer/create-react-app that referenced this pull request Dec 7, 2016
@mofelee
Merge branch 'master' into sparta-webapp
f8c88af 
* master: (30 commits)
  Relax peerDependencies for ESLint preset (facebook#1191)
  Update Webpack to fix source map issues (facebook#1188)
  Update webpack prod config (facebook#1181)
  Chrome 'open tab' reuse an empty tab when possible (facebook#1165)
  Use file-loader for svgs (facebook#1180)
  Fix Babel issues in tests by applying the right transforms (facebook#1179)
  [babel-preset-react-app] Temporary fix missing babel plugins (facebook#1177)
  Add Subresource Integrity support (facebook#1176)
  Remove path module from webpack config on eject. (facebook#1175)
  Don't strip stack traces of evaluated webpack bundles (facebook#1050)
  Add deploy to Firebase CDN on template's README (Closes facebook#374) (facebook#1143)
  Update e2e.sh (facebook#1167)
  Document what npm build does and pushState (facebook#933)
  Fix minor typo/grammar (facebook#1099)
  Add "npm run build silently fails" to Troubleshooting (facebook#1168)
  Add testURL to jest config (facebook#1120)
  Make jsx-no-undef rule an error (facebook#1159)
  Update CHANGELOG.md
  Publish
  Update changelog for 0.8.1
  ...
@gaearon gaearon mentioned this pull request Dec 7, 2016
Merged
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
@alexdriaguine
Add Subresource Integrity support (facebook#1176)
d17e02e 
* Add Subresource Integrity support

* Pin dependency
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
@randycoulman
Add Subresource Integrity support (facebook#1176)
ca876ed 
* Add Subresource Integrity support

* Pin dependency
@ghost
Copy link

ghost commented Dec 18, 2017

Excuse me, how to use this? My final build doesn't contains SRI at all. What I'm doing wrong? In this page I can't find anything: https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md

@XVincentX
Copy link
Author

@johnunclesam As far as I remember, the support has been unfortunately reverted.

@ghost
Copy link

ghost commented Dec 18, 2017

@XVincentX but why Vincent? Can we add it again today?

@XVincentX
Copy link
Author

See #1231 for more details

@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: new feature
Projects
None yet
Milestone
0.8.2
Development

Successfully merging this pull request may close these issues.
3 participants
@XVincentX @gaearon @facebook-github-bot