Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

Allow react 0.14.0-beta1? #219

Closed
cesarandreu opened this issue Jul 29, 2015 · 5 comments
Closed

Allow react 0.14.0-beta1? #219

cesarandreu opened this issue Jul 29, 2015 · 5 comments

Comments

@cesarandreu
Copy link

If it works with it, that is :D.

@grydstedt
Copy link

+1

@pieterv
Copy link
Contributor

pieterv commented Aug 15, 2015

FixedDataTable will definitely work with the beta since FB runs React master internally. But last time i tried to do this i couldn't get the npm dependencies to allow a beta as well as the normal versions. If anyones has an idea how the npm dependency versioning should look for this i will be happy to do the release.

@cesarandreu
Copy link
Author

That's great to hear @pieterv! As a work-around I've just been vendoring or using forked versions, but it's far from ideal :(.

Based on this issue's discussion, it looks like you could set the dependency to:

{
  "peerDependencies": {
    "react": ">=0.13.0 || ^0.14.0-alpha"
  }
}

Looking at libs in the wild, react-dnd's package.json has:

{
  "peerDependencies": {
    "react": ">=0.13.0 <0.15.0 || 0.14.0-beta1"
  }
}

However, (I think?) that won't work with newer 0.14 releases. (e.g. 0.14.0-beta3)

Another lib, react-redux, apparently just straight-up removed the peer dependency.

@ehzhang
Copy link
Contributor

ehzhang commented Aug 17, 2015

So as to keep with the latest releases with react, we've added support for React v0.14.0-beta3 with v0.4.6 (but not beta1 or beta2).

@pieterv
Copy link
Contributor

pieterv commented Aug 17, 2015

@cesarandreu thanks for the info! Let us know if the release doesn't solve the problem for you.

@pieterv pieterv closed this as completed Aug 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants