Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Make sure layer queries hash into leaves of layer proof" #158

Closed
RobinLinus opened this issue Feb 24, 2023 · 2 comments
Closed

"Make sure layer queries hash into leaves of layer proof" #158

RobinLinus opened this issue Feb 24, 2023 · 2 comments

Comments

@RobinLinus
Copy link

In this line there's a TODO saying "make sure layer queries hash into leaves of layer proof". Sounds like the verifier currently does not verify that, or is it verified somewhere else?

@irakliyk
Copy link
Collaborator

This is more for a "debug" type check to make sure the code which actually computes hashes of leaves works correctly. The code that does this is located here.

I do think that this structure is more complicated than it needs to be and I'd love to refactor it at some point (i.e., by abstracting away Merkle trees behind a VectorCommitment trait).

@irakliyk
Copy link
Collaborator

irakliyk commented Jul 8, 2024

Closed by #285.

@irakliyk irakliyk closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants