From 9a20d6ef6095dd9680376fedc24c7c34cc5f33e0 Mon Sep 17 00:00:00 2001 From: Yikun Jiang Date: Sat, 21 Sep 2019 10:52:07 +0800 Subject: [PATCH] Remove invalid comparison of va_list and nullptr MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The comparison of va_list and nullptr is always False under any arch, and will raise invalid operands of types erorr in aarch64 env (error: invalid operands of types ‘va_list {aka __va_list}’ and ‘std::nullptr_t’ to binary ‘operator!=’). This patch removes this invalid assert. Closes: https://github.com/facebook/rocksdb/issues/4277 --- java/rocksjni/loggerjnicallback.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/java/rocksjni/loggerjnicallback.cc b/java/rocksjni/loggerjnicallback.cc index 61571e98712..a731fdac96e 100644 --- a/java/rocksjni/loggerjnicallback.cc +++ b/java/rocksjni/loggerjnicallback.cc @@ -131,7 +131,6 @@ void LoggerJniCallback::Logv(const InfoLogLevel log_level, const char* format, } assert(format != nullptr); - assert(ap != nullptr); const std::unique_ptr msg = format_str(format, ap); // pass msg to java callback handler