Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relay Resolver has module resolution problem in TypeScript #4056

Open
chriserickson opened this issue Sep 2, 2022 · 0 comments
Open

Relay Resolver has module resolution problem in TypeScript #4056

chriserickson opened this issue Sep 2, 2022 · 0 comments

Comments

@chriserickson
Copy link

Same issue as #3989, but it was not completely fixed.

The dynamic imports in the AST omit extensions, however the type imports still have the extensions.

It appears that

fn write_import_module_default(&mut self, name: &str, from: &str) -> FmtResult {

and
fn write_import_type(&mut self, types: &[&str], from: &str) -> FmtResult {

Both also need to strip extensions, as typescript requires that extensions not be provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant