From 66fc7a0b8142920557d3e07fa232112414d7d80e Mon Sep 17 00:00:00 2001 From: Jordan Eldredge Date: Fri, 20 Sep 2024 11:17:07 -0700 Subject: [PATCH] Fix up handle snapshot errors tests (#4801) Summary: I'm not sure how this got in a bad state. Maybe a land race/bad merge? Pull Request resolved: https://github.com/facebook/relay/pull/4801 Reviewed By: gordyf Differential Revision: D63132096 Pulled By: captbaritone fbshipit-source-id: 556101f15ab52da534be701fca6e5380c9b02b81 --- .../handlePotentialSnapshotErrors-test.js | 36 ++++++++++--------- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/packages/relay-runtime/util/__tests__/handlePotentialSnapshotErrors-test.js b/packages/relay-runtime/util/__tests__/handlePotentialSnapshotErrors-test.js index 7a1792122487..23d79c49b712 100644 --- a/packages/relay-runtime/util/__tests__/handlePotentialSnapshotErrors-test.js +++ b/packages/relay-runtime/util/__tests__/handlePotentialSnapshotErrors-test.js @@ -373,24 +373,26 @@ describe('handlePotentialSnapshotErrors', () => { /^Relay: Unexpected response payload - this object includes an errors property in which you can access the underlying errors/, ); - expect(relayFieldLogger).toHaveBeenCalledTimes(2); - expect(relayFieldLogger).toHaveBeenCalledWith({ - error: { - message: 'testMessage', - path: ['testPath'], - severity: 'CRITICAL', - }, - fieldPath: 'testPath', - kind: 'relay_field_payload.error', - owner: 'testOwner', - shouldThrow: true, - }); + const eventsLogged = relayFieldLogger.mock.calls.map(call => call[0]); - expect(relayFieldLogger).toHaveBeenCalledWith({ - fieldPath: '', - kind: 'missing_expected_data.throw', - owner: '', - }); + expect(eventsLogged).toEqual([ + { + error: { + message: 'testMessage', + path: ['testPath'], + severity: 'CRITICAL', + }, + fieldPath: 'testPath', + kind: 'relay_field_payload.error', + owner: 'testOwner', + shouldThrow: true, + }, + { + fieldPath: '', + kind: 'missing_expected_data.log', + owner: 'RelayModernStoreSubscriptionsTest1Fragment', + }, + ]); }); });