From 2edce9f6a73f0567a4988cb89ad295d0f7624ba6 Mon Sep 17 00:00:00 2001
From: Jan Kassens <jkassens@fb.com>
Date: Thu, 2 Apr 2020 08:16:44 -0700
Subject: [PATCH] remove redundant check for node type

Summary:
Just a minor update before making a broader change to the code.

Probably due to some code moves, there was a redundant check for the `generatedNode.kind` that we can get rid of.

Reviewed By: tyao1

Differential Revision: D20796511

fbshipit-source-id: c706eb82fccefad3408c92f888d7ce8cd81f8958
---
 .../codegen/writeRelayGeneratedFile.js        | 40 +++++++------------
 1 file changed, 15 insertions(+), 25 deletions(-)

diff --git a/packages/relay-compiler/codegen/writeRelayGeneratedFile.js b/packages/relay-compiler/codegen/writeRelayGeneratedFile.js
index af62ef813d430..12124b4a227df 100644
--- a/packages/relay-compiler/codegen/writeRelayGeneratedFile.js
+++ b/packages/relay-compiler/codegen/writeRelayGeneratedFile.js
@@ -121,7 +121,6 @@ async function writeRelayGeneratedFile(
         writeQueryParameters &&
         oldRequestParameters &&
         queryParametersFilename != null &&
-        generatedNode.kind === RelayConcreteNode.REQUEST &&
         generatedNode.params.operationKind === 'query'
       ) {
         writeQueryParameters(
@@ -143,30 +142,21 @@ async function writeRelayGeneratedFile(
       return null;
     }
     if (persistQuery) {
-      switch (generatedNode.kind) {
-        case RelayConcreteNode.REQUEST:
-          const {text} = generatedNode.params;
-          invariant(
-            text != null,
-            'writeRelayGeneratedFile: Expected `text` in order to persist query',
-          );
-          generatedNode = {
-            ...generatedNode,
-            params: {
-              id: await persistQuery(text),
-              metadata: generatedNode.params.metadata,
-              name: generatedNode.params.name,
-              operationKind: generatedNode.params.operationKind,
-              text: null,
-            },
-          };
-          break;
-        case RelayConcreteNode.FRAGMENT:
-          // Do not persist fragments.
-          break;
-        default:
-          (generatedNode.kind: empty);
-      }
+      const {text} = generatedNode.params;
+      invariant(
+        text != null,
+        'writeRelayGeneratedFile: Expected `text` in order to persist query',
+      );
+      generatedNode = {
+        ...generatedNode,
+        params: {
+          id: await persistQuery(text),
+          metadata: generatedNode.params.metadata,
+          name: generatedNode.params.name,
+          operationKind: generatedNode.params.operationKind,
+          text: null,
+        },
+      };
     }
   }