From 8d3f39dd3bcdc2a2202ff5092e5ec075b31698a7 Mon Sep 17 00:00:00 2001 From: bubucuo <276185876@qq.com> Date: Wed, 6 Mar 2024 16:08:39 +0800 Subject: [PATCH 1/4] useless returnFiber There is no use of returnFiber here, it can be removed. --- .gitignore | 2 ++ .yarnrc.yml | 1 + packages/react-reconciler/src/ReactChildFiber.js | 5 ++--- 3 files changed, 5 insertions(+), 3 deletions(-) create mode 100644 .yarnrc.yml diff --git a/.gitignore b/.gitignore index 6ec345e172e5e..3781492a29d2e 100644 --- a/.gitignore +++ b/.gitignore @@ -24,6 +24,8 @@ chrome-user-data *.swp *.swo +.yarn/* + packages/react-devtools-core/dist packages/react-devtools-extensions/chrome/build packages/react-devtools-extensions/chrome/*.crx diff --git a/.yarnrc.yml b/.yarnrc.yml new file mode 100644 index 0000000000000..3186f3f0795ab --- /dev/null +++ b/.yarnrc.yml @@ -0,0 +1 @@ +nodeLinker: node-modules diff --git a/packages/react-reconciler/src/ReactChildFiber.js b/packages/react-reconciler/src/ReactChildFiber.js index 1a3b35f816b41..e06371e67b81c 100644 --- a/packages/react-reconciler/src/ReactChildFiber.js +++ b/packages/react-reconciler/src/ReactChildFiber.js @@ -438,7 +438,6 @@ function createChildReconciler( } function mapRemainingChildren( - returnFiber: Fiber, currentFirstChild: Fiber, ): Map { // Add the remaining children to a temporary map so that we can find them by @@ -1194,7 +1193,7 @@ function createChildReconciler( } // Add all children to a key map for quick lookups. - const existingChildren = mapRemainingChildren(returnFiber, oldFiber); + const existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves. for (; newIdx < newChildren.length; newIdx++) { @@ -1404,7 +1403,7 @@ function createChildReconciler( } // Add all children to a key map for quick lookups. - const existingChildren = mapRemainingChildren(returnFiber, oldFiber); + const existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves. for (; !step.done; newIdx++, step = newChildren.next()) { From 1dd9916009b1efb0dd940027b123e0975d337894 Mon Sep 17 00:00:00 2001 From: bubucuo <276185876@qq.com> Date: Wed, 6 Mar 2024 16:13:45 +0800 Subject: [PATCH 2/4] useless returnFiber There is no use of returnFiber here, it can be removed. --- packages/react-reconciler/src/ReactChildFiber.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/react-reconciler/src/ReactChildFiber.js b/packages/react-reconciler/src/ReactChildFiber.js index e06371e67b81c..1a3b35f816b41 100644 --- a/packages/react-reconciler/src/ReactChildFiber.js +++ b/packages/react-reconciler/src/ReactChildFiber.js @@ -438,6 +438,7 @@ function createChildReconciler( } function mapRemainingChildren( + returnFiber: Fiber, currentFirstChild: Fiber, ): Map { // Add the remaining children to a temporary map so that we can find them by @@ -1193,7 +1194,7 @@ function createChildReconciler( } // Add all children to a key map for quick lookups. - const existingChildren = mapRemainingChildren(oldFiber); + const existingChildren = mapRemainingChildren(returnFiber, oldFiber); // Keep scanning and use the map to restore deleted items as moves. for (; newIdx < newChildren.length; newIdx++) { @@ -1403,7 +1404,7 @@ function createChildReconciler( } // Add all children to a key map for quick lookups. - const existingChildren = mapRemainingChildren(oldFiber); + const existingChildren = mapRemainingChildren(returnFiber, oldFiber); // Keep scanning and use the map to restore deleted items as moves. for (; !step.done; newIdx++, step = newChildren.next()) { From 0fe9bf72e66e17b510bc19918a10817800135206 Mon Sep 17 00:00:00 2001 From: bubucuo <276185876@qq.com> Date: Wed, 6 Mar 2024 16:17:53 +0800 Subject: [PATCH 3/4] useless returnFiber There is no use of returnFiber here, it can be removed. --- packages/react-reconciler/src/ReactChildFiber.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/react-reconciler/src/ReactChildFiber.js b/packages/react-reconciler/src/ReactChildFiber.js index 1a3b35f816b41..e06371e67b81c 100644 --- a/packages/react-reconciler/src/ReactChildFiber.js +++ b/packages/react-reconciler/src/ReactChildFiber.js @@ -438,7 +438,6 @@ function createChildReconciler( } function mapRemainingChildren( - returnFiber: Fiber, currentFirstChild: Fiber, ): Map { // Add the remaining children to a temporary map so that we can find them by @@ -1194,7 +1193,7 @@ function createChildReconciler( } // Add all children to a key map for quick lookups. - const existingChildren = mapRemainingChildren(returnFiber, oldFiber); + const existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves. for (; newIdx < newChildren.length; newIdx++) { @@ -1404,7 +1403,7 @@ function createChildReconciler( } // Add all children to a key map for quick lookups. - const existingChildren = mapRemainingChildren(returnFiber, oldFiber); + const existingChildren = mapRemainingChildren(oldFiber); // Keep scanning and use the map to restore deleted items as moves. for (; !step.done; newIdx++, step = newChildren.next()) { From 5c649ba160ea3cf7e717f8f46e59e32e75cc2e14 Mon Sep 17 00:00:00 2001 From: bubucuo <276185876@qq.com> Date: Wed, 6 Mar 2024 16:19:23 +0800 Subject: [PATCH 4/4] reset reset --- .gitignore | 2 -- .yarnrc.yml | 1 - 2 files changed, 3 deletions(-) delete mode 100644 .yarnrc.yml diff --git a/.gitignore b/.gitignore index 3781492a29d2e..6ec345e172e5e 100644 --- a/.gitignore +++ b/.gitignore @@ -24,8 +24,6 @@ chrome-user-data *.swp *.swo -.yarn/* - packages/react-devtools-core/dist packages/react-devtools-extensions/chrome/build packages/react-devtools-extensions/chrome/*.crx diff --git a/.yarnrc.yml b/.yarnrc.yml deleted file mode 100644 index 3186f3f0795ab..0000000000000 --- a/.yarnrc.yml +++ /dev/null @@ -1 +0,0 @@ -nodeLinker: node-modules