From 9ea55ba5c2d035796e4e005e2cd1234468c0c651 Mon Sep 17 00:00:00 2001 From: Nicole Levy Date: Tue, 3 Apr 2018 19:34:39 -0400 Subject: [PATCH 1/6] update warning text --- .../src/__tests__/ReactDOMComponent-test.js | 16 +++++++++++++--- .../ReactServerRendering-test.internal.js | 10 ++++++---- 2 files changed, 19 insertions(+), 7 deletions(-) diff --git a/packages/react-dom/src/__tests__/ReactDOMComponent-test.js b/packages/react-dom/src/__tests__/ReactDOMComponent-test.js index 2df33293fae3f..00c917300cbc6 100644 --- a/packages/react-dom/src/__tests__/ReactDOMComponent-test.js +++ b/packages/react-dom/src/__tests__/ReactDOMComponent-test.js @@ -1000,7 +1000,11 @@ describe('ReactDOMComponent', () => { expect(() => { returnedValue = ReactDOMServer.renderToString(); - }).toWarnDev('
is using uppercase HTML.'); + }).toWarnDev( + '
is using incorrect casing. ' + + 'Use PascalCase for React components, ' + + 'or lowercase letters and dashes for HTML.', + ); expect(returnedValue).not.toContain('
'); }); @@ -1012,7 +1016,11 @@ describe('ReactDOMComponent', () => { expect(() => ReactTestUtils.renderIntoDocument(React.createElement('IMG')), - ).toWarnDev(' is using uppercase HTML.'); + ).toWarnDev( + ' is using incorrect casing. ' + + 'Use PascalCase for React components, ' + + 'or lowercase letters and dashes for HTML.', + ); }); it('should warn on props reserved for future use', () => { @@ -1059,7 +1067,9 @@ describe('ReactDOMComponent', () => { expect(() => ReactTestUtils.renderIntoDocument(), ).toWarnDev([ - ' is using uppercase HTML', + ' is using incorrect casing. ' + + 'Use PascalCase for React components, ' + + 'or lowercase letters and dashes for HTML.', 'The tag is unrecognized in this browser', ]); } finally { diff --git a/packages/react-dom/src/__tests__/ReactServerRendering-test.internal.js b/packages/react-dom/src/__tests__/ReactServerRendering-test.internal.js index 45fca606342f4..c208b28a4be44 100644 --- a/packages/react-dom/src/__tests__/ReactServerRendering-test.internal.js +++ b/packages/react-dom/src/__tests__/ReactServerRendering-test.internal.js @@ -602,11 +602,13 @@ describe('ReactDOMServer', () => { , ), ).toWarnDev([ - 'Warning: is using uppercase HTML. Always use lowercase ' + - 'HTML tags in React.', + 'Warning: is using incorrect casing. ' + + 'Use PascalCase for React components, ' + + 'or lowercase letters and dashes for HTML.', // linearGradient doesn't warn - 'Warning: